Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add e2e integration testing for extension #139

Closed
webknjaz opened this issue Jul 30, 2021 · 2 comments · Fixed by #208
Closed

Add e2e integration testing for extension #139

webknjaz opened this issue Jul 30, 2021 · 2 comments · Fixed by #208
Assignees
@ssbarnea
Labels
AAP Ansible automation platform feature New feature or request help wanted Extra attention is needed major Major or breaking change

Comments

@webknjaz
Copy link
Member

webknjaz commented Jul 30, 2021 •
edited
Loading

Is your feature request related to a problem? Please describe.

No tests.

Describe the solution you'd like

Tests must exist.

Describe alternatives you've considered

Giving up on quality.

Additional context

There's not many good examples of writing integration tests for VS Code extensions so here's some pointers I've found:
@webknjaz webknjaz added feature New feature or request help wanted Extra attention is needed labels Jul 30, 2021
@webknjaz webknjaz added the new label Aug 16, 2021
@webknjaz webknjaz mentioned this issue Sep 9, 2021
Closed
@webknjaz webknjaz added major Major or breaking change and removed new labels Sep 13, 2021
@ssbarnea ssbarnea mentioned this issue Sep 28, 2021
Merged
ssbarnea added a commit to ssbarnea/vscode-ansible that referenced this issue Sep 28, 2021
@ssbarnea
chore: bootstrap test runner
7d9cee1 
Configure the project to use test runner and just install the extension
using it.

Partial-Fix: ansible#139
ssbarnea added a commit to ssbarnea/vscode-ansible that referenced this issue Sep 29, 2021
@ssbarnea
chore: bootstrap test runner
9331e8b 
Configure the project to use test runner and just install the extension
using it.

Partial-Fix: ansible#139
@ssbarnea ssbarnea mentioned this issue Sep 29, 2021
Merged
@webknjaz
Copy link
Member Author

I don't think this should be closed. There's no test examples, it's not solved.

@webknjaz webknjaz reopened this Sep 29, 2021
@ssbarnea ssbarnea mentioned this issue Sep 30, 2021
Closed
@ssbarnea
Copy link
Member

True, it should be open until we finish setting the framework and a minimal battery of testing, so others can easily add more of them while adding other features of bugfixes.

vscode-extension-tester is already used now and it looks promising.

@webknjaz webknjaz mentioned this issue Oct 5, 2021
Open
3 tasks
@ssbarnea ssbarnea changed the title [TODO] Figure out integration testing of this extension Add e2e integration testing of this extension Oct 5, 2021
@ssbarnea ssbarnea self-assigned this Oct 5, 2021
@ssbarnea ssbarnea changed the title Add e2e integration testing of this extension Add e2e integration testing for extension Oct 5, 2021
@ssbarnea ssbarnea linked a pull request Oct 5, 2021 that will close this issue
feat: introduce ui tests based on vscode-extension-tester #208
Merged
@ssbarnea ssbarnea mentioned this issue Oct 5, 2021
Merged
@ganeshrn ganeshrn added the AAP Ansible automation platform label Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssbarnea ssbarnea

Labels
AAP Ansible automation platform feature New feature or request help wanted Extra attention is needed major Major or breaking change
Projects
🧰 devtools project board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: introduce ui tests based on vscode-extension-tester odockal/vscode-ansible
3 participants
@ssbarnea @webknjaz @ganeshrn