Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore schema verification for some files #169

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: restore schema verification for some files #169

merged 1 commit into from
Sep 8, 2021

Conversation

ssbarnea
Copy link
Member

With the exception of playbook and task files, the other ones do not have support from the language-server yet. So we restore the use of YAML schemas for these, like we had on old version.

@ssbarnea
fix: restore schema verification for some files
77cca97 
With the exception of playbook and task files, the other ones do not
have support from the language-server yet. So we restore the use
of YAML schemas for these, like we had on old version.
@ssbarnea ssbarnea added the bug Something isn't working label Aug 24, 2021
@ssbarnea ssbarnea requested a review from webknjaz August 24, 2021 10:23
ganeshrn
ganeshrn approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@ganeshrn ganeshrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. As and when the completion support for missing schema's and file association logic is added to the language server this dependency on YAML extension can be removed from client.

@ssbarnea ssbarnea merged commit 5ef7df7 into main Sep 8, 2021
@ssbarnea ssbarnea deleted the feature/schemas branch September 8, 2021 17:25
ssbarnea pushed a commit that referenced this pull request Mar 15, 2024
@webknjaz
Add a change note for PR #169
76ebdf1
@ssbarnea ssbarnea mentioned this pull request Mar 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webknjaz webknjaz webknjaz approved these changes

@ganeshrn ganeshrn ganeshrn approved these changes

@JPinkney JPinkney JPinkney approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ssbarnea @webknjaz @ganeshrn @JPinkney