Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library import when smoke tests/wheel build #347

Open
germa89 opened this issue Oct 9, 2023 · 8 comments · May be fixed by #353
Open

Library import when smoke tests/wheel build #347

germa89 opened this issue Oct 9, 2023 · 8 comments · May be fixed by #353

Comments

@germa89
Copy link
Contributor

germa89 commented Oct 9, 2023

I think we should explicitly import the library during the smoke testing step. Maybe we are importing it when using importlib_metadata but I'm not sure/it is not clear.

Like in here: ansys/pymapdl#2399

@RobPasMue
Copy link
Member

This is being done for sure since we are getting the version and name of the Python package to generare the wheel. And for that purpose we import the library

@RobPasMue
Copy link
Member

- name: "Verify library is properly installed and get its version number"

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

Is using importlib_metadata to get the version enough to consider the library as loaded/imported? I am not sure. Anyways, I would think something explicit is better.

version=$(python -c "import importlib_metadata; print(importlib_metadata.version('$library_name'))")

@RobPasMue RobPasMue reopened this Oct 16, 2023
@RobPasMue
Copy link
Member

https://chat.openai.com/share/f612b801-49e9-4167-bdb5-f586151fc7e7

ChatGPT proved me wrong... thanks ChatGPT 😄

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

By the way, I tested locally xDD

image

@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

I will do the PR, it will take seconds and surely guys you are so happy to see me around this repo xDDD

@RobPasMue
Copy link
Member

RobPasMue commented Oct 16, 2023

I will do the PR, it will take seconds and surely guys you are so happy to see me around this repo xDDD

New faces contributing! 😄

@germa89 germa89 linked a pull request Oct 16, 2023 that will close this issue
@germa89
Copy link
Contributor Author

germa89 commented Oct 16, 2023

I will do the PR, it will take seconds and surely guys you are so happy to see me around this repo xDDD

New faces contributing! 😄

irony

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants