Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of Point2D and Point3D classes #146

Closed
3 tasks done
Tracked by #91
RobPasMue opened this issue Sep 29, 2022 · 1 comment · Fixed by #156
Closed
3 tasks done
Tracked by #91

Implementation of Point2D and Point3D classes #146

RobPasMue opened this issue Sep 29, 2022 · 1 comment · Fixed by #156
Assignees
@chadqueen @RobPasMue
Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog

Comments

@RobPasMue
Copy link
Member

RobPasMue commented Sep 29, 2022 •
edited
Loading

From #96 it was decided to go ahead and fall back to our previous 2D/3D specific implementation for the actual Point objects. This task implies:

  • Refactoring
  • Support for mathematical operations: __add__, __sub__
  • Check that the outcome of any of the operators is not ill-formed (i.e. the resulting Point has all its expected properties, attributes)
@RobPasMue RobPasMue changed the title Implementation of Point2D and Point3D classes. Implementation of Point2D and Point3D classes Sep 29, 2022
@RobPasMue RobPasMue added the PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog label Sep 29, 2022
@RobPasMue RobPasMue mentioned this issue Sep 29, 2022
Closed
7 tasks
@chadqueen chadqueen self-assigned this Oct 3, 2022
@chadqueen
Copy link
Contributor

https://github.com/pyansys/pygeometry/tree/maint%2Fdimensions

@chadqueen chadqueen linked a pull request Oct 4, 2022 that will close this issue
Revise Point and Vector to have dimension specific class implementations #156
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chadqueen chadqueen

@RobPasMue RobPasMue

Labels
PRIORITY Issue/PR assigned with this tag must be given priority over the rest of the backlog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Revise Point and Vector to have dimension specific class implementations ansys/pyansys-geometry
2 participants
@chadqueen @RobPasMue