Created api commands for mag, pres and temp and volt #764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created equivalent pymapdl commands for the 3 scalar queries: MAG, PRES, and TEMP. Examples have only been added for one of the three and tests for none of them because my knowledge of APDL is not extensive enough. Further work will require external input.
jgd10
changed the title
|
Thanks for adding this. Will need tests for these (eventually). |
* Updated temperature example
Updated temperature example, but still need to fix temperature description
* Added Examples for querying TEMP, PRES,VOLT and MAG results
I have added examples to extract the Temperature, Pressure, Voltage and Magnetic Scalar Potential at node ID 1 of the solved model.
Also, I have corrected the _run_query(f"VOLT({n})" to _run_query(f"MAG({n})" for Magnetic Scalar Potential example
* Made changes due to Review
Removed the Print statements in Volt and Mag examples
|
Examples reviewed and merged in (to this branch, not main). Just tests left! |
* Updated temperature example
Updated temperature example, but still need to fix temperature description
* Added Examples for querying TEMP, PRES,VOLT and MAG results
I have added examples to extract the Temperature, Pressure, Voltage and Magnetic Scalar Potential at node ID 1 of the solved model.
Also, I have corrected the _run_query(f"VOLT({n})" to _run_query(f"MAG({n})" for Magnetic Scalar Potential example
* Made changes due to Review
Removed the Print statements in Volt and Mag examples
* Added Tests for field component values
Added tests for Temp, Pressure, Volt and Mag component values.
|
I will do a bit of refactoring of the tests into fixtures and then remove the "do not merge" tag and it can be reviewed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created equivalent pymapdl commands for the 4 scalar queries: MAG, PRES, VOLT,
and TEMP. Examples have only been added for one of the four and tests
for none of them because my knowledge of APDL is not extensive enough.
Further work will require external input.
@RGPATCHI Can you create the examples for the commands without them? In addition we can work on tests for the three new functions together.