Feat/field component tests #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated temperature example, but still need to fix temperature description
I have added examples to extract the Temperature, Pressure, Voltage and Magnetic Scalar Potential at node ID 1 of the solved model.
Also, I have corrected the _run_query(f"VOLT({n})" to _run_query(f"MAG({n})" for Magnetic Scalar Potential example
Removed the Print statements in Volt and Mag examples
Added tests for Temp, Pressure, Volt and Mag component values.
RGPATCHI
changed the base branch from
main
to
feat/issue_504_field_components
|
Might be worth moving the setup method to a fixture but we can do that in the final PR #764 |
|
otherwise LGTM! |
Note this is merging into a branch of pymapdl that is NOT main, at this stage. |
akaszynski
pushed a commit
that referenced
this pull request
Jan 14, 2022
* Created api commands for mag, pres and temp Created equivalent pymapdl commands for the 3 scalar queries: MAG, PRES, and TEMP. Examples have only been added for one of the three and tests for none of them because my knowledge of APDL is not extensive enough. Further work will require external input. * Updated temperature example (#780) * Updated temperature example Updated temperature example, but still need to fix temperature description * Added Examples for querying TEMP, PRES,VOLT and MAG results I have added examples to extract the Temperature, Pressure, Voltage and Magnetic Scalar Potential at node ID 1 of the solved model. Also, I have corrected the _run_query(f"VOLT({n})" to _run_query(f"MAG({n})" for Magnetic Scalar Potential example * Made changes due to Review Removed the Print statements in Volt and Mag examples * Feat/field component tests (#833) * Updated temperature example Updated temperature example, but still need to fix temperature description * Added Examples for querying TEMP, PRES,VOLT and MAG results I have added examples to extract the Temperature, Pressure, Voltage and Magnetic Scalar Potential at node ID 1 of the solved model. Also, I have corrected the _run_query(f"VOLT({n})" to _run_query(f"MAG({n})" for Magnetic Scalar Potential example * Made changes due to Review Removed the Print statements in Volt and Mag examples * Added Tests for field component values Added tests for Temp, Pressure, Volt and Mag component values. * refactored test setup into a fixture Co-authored-by: RGPATCHI <84843983+RGPATCHI@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for field component values