fix(module: select): fix null value #1786

anranruye · 2021-07-28T02:07:43Z

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language	Changelog
🇺🇸 English	accept `null` as select option value
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

Doc is updated/provided or not needed
Demo is updated/provided or not needed
Changelog is provided or not needed

github-actions · 2021-07-28T02:07:54Z

codecov · 2021-07-28T02:29:48Z

Codecov Report

Merging #1786 (b40e11a) into master (e07a9f8) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b40e11a differs from pull request most recent head ea32b84. Consider uploading reports for the commit ea32b84 to get more accurate results

@@           Coverage Diff           @@
##           master    #1786   +/-   ##
=======================================
  Coverage   20.78%   20.78%           
=======================================
  Files         478      478           
  Lines       30452    30452           
=======================================
  Hits         6328     6328           
  Misses      24124    24124

Impacted Files	Coverage Δ
components/select/Select.razor.cs	`38.79% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e07a9f8...ea32b84. Read the comment docs.

anddrzejb

LGTM

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>

fix(module: select): fix null value

b40e11a

pr-triage bot added the PR: unreviewed label Jul 28, 2021

ElderJames requested a review from anddrzejb July 28, 2021 07:43

anddrzejb approved these changes Jul 28, 2021

View reviewed changes

pr-triage bot added PR: reviewed-approved and removed PR: unreviewed labels Jul 28, 2021

ElderJames approved these changes Jul 28, 2021

View reviewed changes

Merge branch 'master' into FixSelectNullValue

ea32b84

pr-triage bot added PR: unreviewed and removed PR: reviewed-approved labels Jul 28, 2021

ElderJames enabled auto-merge (squash) July 28, 2021 11:07

ElderJames merged commit 8b41465 into ant-design-blazor:master Jul 28, 2021

pr-triage bot added PR: merged and removed PR: unreviewed labels Jul 28, 2021

anddrzejb pushed a commit to anddrzejb/ant-design-blazor that referenced this pull request Jul 29, 2021

fix(module: select): fix null value (ant-design-blazor#1786)

fb7501f

Co-authored-by: James Yeung <shunjiey@hotmail.com>

anranruye deleted the FixSelectNullValue branch August 29, 2021 06:01

anranruye mentioned this pull request Oct 3, 2021

SelectOption doesn't render properly if Value is null #1995

Closed

ElderJames added a commit that referenced this pull request Apr 23, 2022

fix(module: select): fix null value (#1786)

27c06c7

Co-authored-by: James Yeung <shunjiey@hotmail.com>

ElderJames added a commit that referenced this pull request Apr 30, 2022

fix(module: select): fix null value (#1786)

077a297

Co-authored-by: James Yeung <shunjiey@hotmail.com>

ElderJames added a commit that referenced this pull request Sep 6, 2022

fix(module: select): fix null value (#1786)

2b350ec

Co-authored-by: James Yeung <shunjiey@hotmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(module: select): fix null value #1786

fix(module: select): fix null value #1786

anranruye commented Jul 28, 2021

github-actions bot commented Jul 28, 2021 •

edited

codecov bot commented Jul 28, 2021 •

edited

anddrzejb left a comment

fix(module: select): fix null value #1786

fix(module: select): fix null value #1786

Conversation

anranruye commented Jul 28, 2021

🤔 This is a ...

🔗 Related issue link

💡 Background and solution

📝 Changelog

☑️ Self Check before Merge

github-actions bot commented Jul 28, 2021 • edited

codecov bot commented Jul 28, 2021 • edited

Codecov Report

anddrzejb left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 28, 2021 •

edited

codecov bot commented Jul 28, 2021 •

edited