fix(module:overlay): use right positioning for bottom-right placement #1799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #1799 +/- ##
===========================================
+ Coverage 0.00% 23.50% +23.50%
===========================================
Files 478 495 +17
Lines 31107 23196 -7911
Branches 0 121 +121
===========================================
+ Hits 0 5452 +5452
+ Misses 31107 17741 -13366
- Partials 0 3 +3
Continue to review full report at Codecov.
|
ElderJames
approved these changes
Aug 1, 2021
ElderJames
added a commit
that referenced
this pull request
Aug 13, 2021
* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>
15 tasks
ElderJames
pushed a commit
that referenced
this pull request
Apr 23, 2022
ElderJames
added a commit
that referenced
this pull request
Apr 23, 2022
* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames
pushed a commit
that referenced
this pull request
Apr 30, 2022
ElderJames
added a commit
that referenced
this pull request
Apr 30, 2022
* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames
pushed a commit
that referenced
this pull request
Sep 6, 2022
ElderJames
added a commit
that referenced
this pull request
Sep 6, 2022
* refactor(module: table): use EnumSelect for table filter (#1777) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): fix parent checkbox state calculation (#1781) * fix(module: select): remove ValueName null check for non-datasource approach (#1785) * fix(module: select): fix null value (#1786) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776) * fix(module:select) MaxTagCount behaves property for non-responsive scenarios docs: added XML comments fixed order in English docs redid Chinese docs (missing translations) test: add scenario for MaxTagCount when non-responsive * merge with changes coming from feature branch * docs: example of MaxTagCount change Co-authored-by: James Yeung <shunjiey@hotmail.com> * refactor(interop): reorganization into classes and typescript tests (#1791) * fix(module:interop): reorganization into classes * comments clean-up * Add typescript test project * fix: sync with pull request #1765: support drag * github test action fix attempt * tests: jsinterop test mock fix * codecov added to ts tests * add generated split js to gitignore * fix: coverage github action Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794) * fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): fix cascading table in column (#1732) * fix(module: table): fix cascading tables * Update Column.razor * Update Column,razor Co-authored-by: James Yeung <shunjiey@hotmail.com> * feat(module: tree): bring SearchExpression back (#1796) * fix(module: RangePicker): ShowTime issues addressed (#1788) * fix(module:rangePicker): year & month skip * fix(module:rangePicker): extra space removed on 2nd picker * fix(module:rangePicker): when ShowTime, click on OK moves to other picker * fix(module:rangePicker): adjust year skip button * fix(module:rangePicker): focus issue resolution * fix(module:rangePicker): remove incorrect value from input Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: overlay): fix overlay position when container element has border (#1797) * fix(module: overlay): use right positioning for bottom-right placement (#1799) * fix(module: date-picker): update resource files (#1800) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: calendar): fix header select width (#1801) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815) * fix(module: date-picker): fix ShowToday when ShowTime is true (#1819) Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> * doc: fix api markdown for autocomplete (#1808) * Update index.en-US.md * Update index.zh-CN.md Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: table): missing sorter model on first change (#1823) * fix(module: upload): basic functionality restored (#1824) * fix(module: table): use "or" filter condition for List type built-in filter (#1804) Co-authored-by: James Yeung <shunjiey@hotmail.com> * fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825) * fix(module: date-picker): remain millisecond value when change the picker value (#1829) * fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830) * fix(module: table): missing `showTime` of built-in datetime filter (#1827) Co-authored-by: James Yeung <shunjiey@hotmail.com> * changelog 0.9.1 (#1831) Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com> Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com> Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy> Co-authored-by: zxyao <zxyao145@gmail.com> Co-authored-by: 艁ukasz B艂a偶ewicz <lukasz.blazewicz@homebook.pl> Co-authored-by: heroboy <yangweiqin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃 This is a ...
馃敆 Related issue link
Fixes #1531
馃挕 Background and solution
When overlay trigger placement is not bottom-left or right-top, the overlay position will be wrong when the overlay size changes. This pr use right positioning instead of left positioning to solve the table filter scenario. We can extend to other placement type when needed.
馃摑 Changelog
鈽戯笍 Self Check before Merge