Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:rangePicker): ShowTime issues addressed #1788

Merged
merged 7 commits into from
Jul 31, 2021

Conversation

anddrzejb
Copy link
Member

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

  1. Fixes RangePicker 右侧日期选择有很多问题 #1482
    Fixes RangePicker: when ShowTime is enabled, for the second picker, the month grows by 1 when clicking any button #1680
  2. Fixes RangePicker: not revert to valid value after input an invalid value in the first textbox #1677
  3. Fixes RangePicker: Clicking "Ok" button doesn't transfer the cursor to the second textbox #1678
  4. Focus issues
  5. Visual issue for 2nd picker - extra space:
    image

💡 Background and solution

  1. When next month/year was clicked, base year/month (that would be incremented) was taken from the second picker instead of the first, but applied to the first. Solution applied: for the second picker, the value is decreased by predefined value to achieve expected increments.
  2. After my changes, this is no longer recreatable. Either this PR fixed this or was fixed in previous PRs but not mentioned.
  3. Ok click was only closing. Added logic to move to next/previous input.
  4. Addresses focus remaining after selection has been made. There are still a number of issues with focus indication. I have not addressed them here as they are extremely hard to test, due to overlay issues and DatePicker spawning myriad of refresh events. Hopefully these will be easier to solve once at least overlay issues are solved (should at least be possible to write automated tests).
  5. Special scenario for 2nd picker when ShowTime is true - the first picker was rendered as empty div and was causing this extra space. Removed rendering of the first picker div when 2nd is visible.

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Jul 28, 2021

@codecov
Copy link

codecov bot commented Jul 28, 2021

Codecov Report

Merging #1788 (b963364) into master (29a723b) will increase coverage by 23.51%.
The diff coverage is 14.28%.

❗ Current head b963364 differs from pull request most recent head 297e1df. Consider uploading reports for the commit 297e1df to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1788       +/-   ##
===========================================
+ Coverage    0.00%   23.51%   +23.51%     
===========================================
  Files         478      495       +17     
  Lines       31072    23187     -7885     
  Branches        0      121      +121     
===========================================
+ Hits            0     5452     +5452     
+ Misses      31072    17732    -13340     
- Partials        0        3        +3     
Impacted Files Coverage Δ
components/date-picker/RangePicker.razor 0.00% <ø> (ø)
components/date-picker/RangePicker.razor.cs 0.00% <0.00%> (ø)
components/date-picker/internal/DatePickerBase.cs 46.74% <0.00%> (+46.74%) ⬆️
...nts/date-picker/internal/DatePickerDatePanel.razor 70.58% <ø> (+70.58%) ⬆️
...date-picker/internal/DatePickerDatetimePanel.razor 0.00% <0.00%> (ø)
...e-picker/internal/DatePickerDatetimePanel.razor.cs 0.00% <0.00%> (ø)
...s/date-picker/internal/DatePickerDecadePanel.razor 0.00% <ø> (ø)
...ts/date-picker/internal/DatePickerMonthPanel.razor 0.00% <ø> (ø)
.../date-picker/internal/DatePickerQuarterPanel.razor 0.00% <ø> (ø)
...nts/date-picker/internal/DatePickerYearPanel.razor 0.00% <ø> (ø)
... and 449 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29a723b...297e1df. Read the comment docs.

Copy link
Member

@anranruye anranruye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. RangePicker: not revert to valid value after input an invalid value in the first textbox #1677 still exists. To reproduce this issue, you should press "enter" after input.
    动画08

  2. In react antD, the cursor is moved to the prev/next input after clicking "Ok" only one time, then the dropdown is closed. The logic of this PR is different. The cursor is moved to the prev/next input every time "Ok" is clicked unless the picker value is changed(after the picker value is changed, the cursor will still move one time, then the dropdown will be closed).
    动画09
    动画10

3. Focus remaining still happens when not select both date values and the picker wrongly loses focus when switch to the prev/next input(exsiting issue). In the second gif, the week range picker can not lose focus, not sure the condition to reproduce.
动画11
动画12

@anddrzejb
Copy link
Member Author

  1. That is really awkward 😄 . I tested this on 3 different browsers on my machine and everywhere I could not recreate it. And I was trying with Enter key... I will have another look.
  2. It is not a part of this PR. Otherwise I would include the issue where you mention it. My primary goal was to solve the major issue that was making RangePicker with ShowTime unusable. Other issues - will be addressed in future PRs.
  3. So... ok here? I am aware about this issue. Focus issues here gave me a headache and always consume too much of my time. I want to address them only once testing is solved, so I can actually do a fast red-green path.

@anranruye
Copy link
Member

  1. That's strange, I will also have a look.
  2. Yes, this doesn't matter. I didn't mean we should have the same behavior as react ant design at this moment. But I think it's better to have a consistent behavior. Either to always move the cursor, or always close the dropdown. It's ok to make it in the future.
  3. Eventually I think these issues are not parts of this PR.

@anranruye
Copy link
Member

@anddrzejb confirmed that #1677 only happens on blazor wasm, blazor server is ok.

@anddrzejb
Copy link
Member Author

I really was sure I checked wasm. I will have a look once I am avaliable.

@anddrzejb
Copy link
Member Author

I found out what was it. I didn't get it on mine originally, due to the fact that for ant development, I created my own playground project where I usually work on a single component. The issue here is showing only when there are more components and jsinterop is competing with blazor. The problem here is that input value was not yet passed to DatePickerInput and already OnKeyDown event was triggered that was actually checking that value (and clearing it if it was incorrect). I do not know how else to solve this problem, except by using await Task.Delay() method, so this is how I solved it. This solution also fixed a different bug in server side - when incorrect value was entered, the input was cleared but focus was being moved to the next input. Now it stays on the same input - same as react antD.

@anddrzejb anddrzejb requested a review from anranruye July 30, 2021 21:34
@ElderJames ElderJames enabled auto-merge (squash) July 31, 2021 10:44
@ElderJames ElderJames merged commit c3cefdd into ant-design-blazor:master Jul 31, 2021
@anddrzejb anddrzejb deleted the dateRangeWithTimeIssue branch August 8, 2021 15:40
ElderJames added a commit that referenced this pull request Aug 13, 2021
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* refactor(module: table): use EnumSelect for table filter (#1777)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): fix parent checkbox state calculation (#1781)

* fix(module: select): remove ValueName null check for non-datasource approach (#1785)

* fix(module: select): fix null value (#1786)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: select): MaxTagCount behaves properly for non-responsive scenarios (#1776)

* fix(module:select) MaxTagCount behaves property for non-responsive scenarios

docs: added XML comments
      fixed order in English docs
      redid Chinese docs (missing translations)

test: add scenario for MaxTagCount when non-responsive

* merge with changes coming from feature branch

* docs: example of MaxTagCount change

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* refactor(interop): reorganization into classes and typescript tests (#1791)

* fix(module:interop): reorganization into classes

* comments clean-up

* Add typescript test project

* fix: sync with pull request #1765: support drag

* github test action fix attempt

* tests: jsinterop test mock fix

* codecov added to ts tests

* add generated split js to gitignore

* fix: coverage github action

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: tree): one more fix to parent checkbox state calculation (#1781) (#1794)

* fix(module: modal): error when confirm TaskCompletionSource SetResult repeat (#1795)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): fix cascading table in column (#1732)

* fix(module: table): fix cascading tables

* Update Column.razor

* Update Column,razor

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: tree): bring SearchExpression back (#1796)

* fix(module: RangePicker): ShowTime issues addressed (#1788)

* fix(module:rangePicker): year & month skip

* fix(module:rangePicker): extra space removed on 2nd picker

* fix(module:rangePicker): when ShowTime, click on OK moves to other picker

* fix(module:rangePicker): adjust year skip button

* fix(module:rangePicker): focus issue resolution

* fix(module:rangePicker): remove incorrect value from input

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: overlay): fix overlay position when container element has border (#1797)

* fix(module: overlay): use right positioning for bottom-right placement (#1799)

* fix(module: date-picker): update resource files (#1800)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: calendar): fix header select width (#1801)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: layout): fix OnBreakpoint and OnCollapse only when they was changed (#1815)

* fix(module: date-picker): fix ShowToday when ShowTime is true (#1819)

Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>

* doc: fix api markdown for autocomplete (#1808)

* Update index.en-US.md

* Update index.zh-CN.md

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): missing sorter model on first change (#1823)

* fix(module: upload): basic functionality restored (#1824)

* fix(module: table): use "or" filter condition for List type built-in filter (#1804)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: auto-complete): turn off the input `autocomplete` attribute (#1825)

* fix(module: date-picker): remain millisecond value when change the picker value (#1829)

* fix(module: input-number): `OnChange` cannot be triggered during keyboard input (#1830)

* fix(module: table): missing `showTime` of built-in datetime filter (#1827)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* changelog 0.9.1 (#1831)

Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Co-authored-by: lukblazewicz <39852149+lukblazewicz@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: Łukasz Błażewicz <lukasz.blazewicz@homebook.pl>
Co-authored-by: heroboy <yangweiqin@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment