Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module: input-number): default value binding #1871

Merged
merged 3 commits into from
Aug 26, 2021

Conversation

ElderJames
Copy link
Member

馃 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

fixed #1870

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English
馃嚚馃嚦 Chinese

鈽戯笍 Self Check before Merge

鈿狅笍 Please check all items below before review. 鈿狅笍

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link

github-actions bot commented Aug 24, 2021

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #1871 (470991e) into master (bdcb4ee) will increase coverage by 23.56%.
The diff coverage is 83.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1871       +/-   ##
===========================================
+ Coverage    0.00%   23.56%   +23.56%     
===========================================
  Files         478      495       +17     
  Lines       31203    23246     -7957     
  Branches        0      121      +121     
===========================================
+ Hits            0     5479     +5479     
+ Misses      31203    17764    -13439     
- Partials        0        3        +3     
Impacted Files Coverage 螖
components/input-number/InputNumber.razor.cs 57.08% <83.33%> (+57.08%) 猬嗭笍
components/card/Card.razor 0.00% <0.00%> (酶)
components/form/Form.razor 0.00% <0.00%> (酶)
components/rate/Rate.razor 0.00% <0.00%> (酶)
components/spin/Spin.razor 0.00% <0.00%> (酶)
components/tree/Tree.razor 0.00% <0.00%> (酶)
components/menu/MenuLink.cs 0.00% <0.00%> (酶)
components/menu/MenuMode.cs 0.00% <0.00%> (酶)
components/steps/Step.razor 0.00% <0.00%> (酶)
components/affix/Affix.razor 0.00% <0.00%> (酶)
... and 438 more

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update bdcb4ee...470991e. Read the comment docs.

@iamSmallY
Copy link
Contributor

iamSmallY commented Aug 24, 2021

ResetValue method in AntInputComponentBase class probably should be override to set the Value as DefaultValue when reset the input component

@ElderJames ElderJames force-pushed the fix/inputnumber-default-value branch from c746f88 to 4b0b4a3 Compare August 25, 2021 15:48
@ElderJames ElderJames merged commit dc35907 into master Aug 26, 2021
@ElderJames ElderJames deleted the fix/inputnumber-default-value branch August 26, 2021 04:51
ElderJames added a commit that referenced this pull request Aug 29, 2021
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: input-number): default value binding

* fix default value
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: input-number): default value binding

* fix default value
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: input-number): default value binding

* fix default value
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InputNumber DefaultValue has no effect
2 participants