Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tag compliance with Blazor conventions #1876

Merged

Conversation

stefanodriussi
Copy link
Contributor

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • Bundle size optimization
  • Performance optimization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

There was a spelling error in the Checked callback name and this caused a runtime error when defining a Tag with two-ways binding because Blazor's runtime couldn't find the method by convention.

While the following code is perfectly fine at compile time

<Tag Checkable @bind-Checked="IsTagChecked" >Tag</Tag>

@code{
    public bool IsTagChecked { get; set; }
}

it fails at runtime with exception
Error: System.InvalidOperationException: Object of type 'AntDesign.Tag' does not have a property matching the name 'CheckedChanged'.

The solution is to add the missing 'd' to the CheckedChange method in order to adhere to Blazor's conventions for two-ways binding

📝 Changelog

Language Changelog
🇺🇸 English Fix two-ways binding in checkable Tag
🇨🇳 Chinese 修复可检查标签中的双向绑定

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Changelog is provided or not needed

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property
@dnfadmin
Copy link

dnfadmin commented Aug 25, 2021

CLA assistant check
All CLA requirements met.

@github-actions
Copy link

github-actions bot commented Aug 25, 2021

ElderJames
ElderJames previously approved these changes Aug 25, 2021
Copy link
Member

@ElderJames ElderJames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@stefanodriussi
Copy link
Contributor Author

My bad 😅
Will fix that as soon as I go back to my desk

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #1876 (2ba1788) into master (a8ccae5) will increase coverage by 23.56%.
The diff coverage is 100.00%.

❗ Current head 2ba1788 differs from pull request most recent head 769ac10. Consider uploading reports for the commit 769ac10 to get more accurate results
Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1876       +/-   ##
===========================================
+ Coverage    0.00%   23.56%   +23.56%     
===========================================
  Files         478      495       +17     
  Lines       31213    23246     -7967     
  Branches        0      121      +121     
===========================================
+ Hits            0     5479     +5479     
+ Misses      31213    17764    -13449     
- Partials        0        3        +3     
Impacted Files Coverage Δ
components/tag/Tag.razor.cs 82.85% <100.00%> (+82.85%) ⬆️
components/card/Card.razor 0.00% <0.00%> (ø)
components/form/Form.razor 0.00% <0.00%> (ø)
components/rate/Rate.razor 0.00% <0.00%> (ø)
components/spin/Spin.razor 0.00% <0.00%> (ø)
components/tree/Tree.razor 0.00% <0.00%> (ø)
components/menu/MenuLink.cs 0.00% <0.00%> (ø)
components/menu/MenuMode.cs 0.00% <0.00%> (ø)
components/steps/Step.razor 0.00% <0.00%> (ø)
components/affix/Affix.razor 0.00% <0.00%> (ø)
... and 438 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8ccae5...769ac10. Read the comment docs.

@ElderJames ElderJames enabled auto-merge (squash) August 27, 2021 06:43
@ElderJames ElderJames merged commit e106606 into ant-design-blazor:master Aug 27, 2021
ElderJames added a commit that referenced this pull request Aug 29, 2021
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 23, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Apr 30, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>
ElderJames added a commit that referenced this pull request Sep 6, 2022
* fix(module: table): fix initial load and render (#1835)

* fix(module: table): fix initial load and render

* delete the useless method

* chore: remove redundant semi-colons (#1812)

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): checked state didn't follow the value change (#1841)

* fix(module: menu): menu item click event should be triggered when menu selectable is false (#1843)

* fix(module: tag): Tag component style parameters are not rendered (#1847)

* fix(module: tag): Tag component style parameters are not rendered (#1846)

* fix(module: tag): change call GetStyle  in OnParameterSet

Co-authored-by: haojiajun <haojiajun@vanelink.net>

* fix(module: tree): SelectedNodeChanged would be fired twice twice (#1849)

* fix(module: table): prevent propagation of expand button click events (#1850)

* changelog 0.9.2 (#1851)

* feat(module: upload): add method parameter (#1853)

* add method parameter to upload component
* update documentation
* add test

Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>

* fix(module: table): avoid `OnChange` being called multiple times during initialization (#1855)

* fix(module: table): avoid OnChange being called multiple times during initialisation

* fix indent

* fix(module: table): didn't refresh when using client side data source (#1858)

* feat(module: table): add TheSameDateWith condition operator for DateTime column (#1856)

* use date in datetime filter

* fix spelling errors

* Restore changes and add Date and Month FilterCompareOperator

* hide time when filter date or month

* Remove the month FilterCompareOperator

* add locale data

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: checkbox): option change does not lock checkboxes (#1863)

* fix(module: table): ignore milliseconds when applying the datetime filter (#1864)

* remove milliseconds when filtering

* remove the milliseconds when set the datetime filter value

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: input-number): default value binding (#1871)

* fix(module: input-number): default value binding

* fix default value

* fix(module: autocomplete): overlay is showing for AutoCompleteSearch (#1860)

* fix(module:autocomplete): overlay is showing for AutoCompleteSearch

* translate comments

* code cleanup

Co-authored-by: ElderJames <shunjiey@hotmail.com>

* fix(module: tag): rename  `CheckedChange` to  `CheckedChanged` (#1876)

* Update Tag compliance with Blazor conventions

Add the missing 'd' to CheckedChanged callback in order to properly support two ways binding on the Checked property

* Fix references to renamed method in Tag component

* Update tests for Tag

Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: James Yeung <shunjiey@hotmail.com>

* feat(module: menu): Add IconTemplate for menu item (#1879)

* docs: update CONTRIBUTING (#1882)

* feat(module: breadcrumb): add `Href` parameter and overlay dropdown (#1859)

* Setup breadcrumb dropdown

* Setup breadcrumb href

* fix dropdown style

* fix dropdown trigger class

* fix tests

Co-authored-by: James Yeung <shunjiey@hotmail.com>

* fix(module: table): call `StateHasChanged` in `InternalReload` (#1874) (#1875)

* fix(module: table): not automatically load with ActionColumn (#1883)

Fixed an issue where a table would not automatically load after initialization when an ActionColumn was used.

* feat(module: table): add nested table demo (#1884)

* fix(module: modal): auto focus the ok button and remove the focus of the trigger button (#1838)

* fix: second opening of focus in modal fails if DestroyOnClose is false

* fix: confirm cannot get focus element

* fix: set ConfirmAutoFocusButton is OK

* fix: module ImagePreview cannot close on second click

* fix: blur active element when comfirm focus element is disabled

* fix(module: table): fix the format issue of datetime samedate filter (#1889)

* changelog 0.9.3 (#1890)

Co-authored-by: Simon Cropp <simon.cropp@gmail.com>
Co-authored-by: JohnHao421 <544106829@qq.com>
Co-authored-by: haojiajun <haojiajun@vanelink.net>
Co-authored-by: Noah Potash <digitalnugget@gmail.com>
Co-authored-by: Noah Potash <noah.potash@outbreaklabs.com>
Co-authored-by: SmallY <45689960+iamSmallY@users.noreply.github.com>
Co-authored-by: Andrzej Bakun <andrzej@neelyc.com.cy>
Co-authored-by: Stefano Driussi <stedri@gmail.com>
Co-authored-by: Stefano Drussi <stefano.driussi@hotmail.it>
Co-authored-by: Guyiming <guyiming2011@126.com>
Co-authored-by: YongQuanRao <79885120+JamesGit-hash@users.noreply.github.com>
Co-authored-by: Maksim <maksalmak@gmail.com>
Co-authored-by: Nikolay Krondev <nikolaykrondev@users.noreply.github.com>
Co-authored-by: zxyao <zxyao145@gmail.com>
Co-authored-by: anranruye <54608128+anranruye@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants