Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: stepper #698

Merged
merged 1 commit into from
Apr 23, 2023
Merged

fix: stepper #698

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/Stepper/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,13 @@
const addTemp = upStep(value, step, precision);
result = Math.min(addTemp, max);
}
const { needUpdate } = this.update(result);
if (this.props.onChange && needUpdate) {
if (!this.isControlled()) {
const { needUpdate } = this.update(result);

Check warning on line 102 in src/Stepper/index.ts

View check run for this annotation

Codecov / codecov/patch

src/Stepper/index.ts#L102 

Added line #L102 was not covered by tests
if (!needUpdate) {
return;

Check warning on line 104 in src/Stepper/index.ts

View check run for this annotation

Codecov / codecov/patch

src/Stepper/index.ts#L104 

Added line #L104 was not covered by tests
}
}
if (this.props.onChange) {
this.props.onChange(result, fmtEvent(this.props, e));
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码的作用是处理数字输入框的值，并在值改变时触发onChange回调。

代码实现上有几个改进点：

  1. isControlled方法是通过props上是否传入value来判断当前组件是受控还是非受控组件，这种方式是比较常见的做法，但可以优化一下：可以考虑在组件初始化时根据props上是否有value属性来设置isControlled标志，在之后不需要每次都重新计算。

  2. 由于这个组件是一个可控组件，因此要优先处理受控情况。在这里，首先判断组件是受控还是非受控状态，如果是非受控组件才会去更新组件的值。

  3. 判断needUpdate变量是否为false可以直接使用if (!needUpdate)的形式，这样会更加简洁。

  4. 当组件处于非受控状态时，更新操作没有被执行，这可能导致父组件和子组件的value值不一致，应该给出提示或者抛出异常。

至于代码是否存在风险，需要更多相关背景信息和上下文来确定。

Expand Down
Loading