fix(textarea-item) #2506
Merged
fix(textarea-item) #2506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
cc @warmhug |
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
=========================================
+ Coverage 58.38% 58.4% +0.01%
=========================================
Files 262 262
Lines 4566 4565 -1
Branches 1289 1289
=========================================
Hits 2666 2666
+ Misses 1895 1894 -1
Partials 5 5
Continue to review full report at Codecov.
|
KgTong
changed the title
paranoidjk
reviewed
May 3, 2018
| @@ -246,7 +243,6 @@ export default class TextareaItem extends React.Component< | |||
| <div | |||
| className={`${prefixCls}-clear`} | |||
| onClick={this.clearInput} | |||
| onTouchStart={this.clearInput} | |||
There was a problem hiding this comment.
看起来没问题，找个 android/ios 分别测试一下吧。
There was a problem hiding this comment.
测过了。在现在m-feedback master代码下，即使加了onTouchStart也不会执行https://github.com/react-component/m-feedback/blob/master/src/TouchFeedback.tsx#L99
BANG88
added a commit
to BANG88/ant-design-mobile
that referenced
this pull request
May 11, 2018
* master: fix: Modal event close ant-design#2486 fix(input-item): user experience regression on non-mutate control (ant-design#2537) fix(input-item): cursor dislocation when typing via system keyboard of UC browser (ant-design#2532) fix(Accordion): make aria-expanded prop valid in preact, close ant-design#2491 (ant-design#2530) fix(input-item): value.substring is not a function (ant-design#2508) demo: add use of listview component nested with tabbar, close ant-design#2455 (ant-design#2527) docs: improve List doc, close ant-design#2514 docs: fix typo (ant-design#2523) fix: style of <SearchBar/> (ant-design#2510) fix: development error fix: upgrade rmc-feedback to 2.x (ant-design#2509) fix(textarea-item) close ant-design#2372 (ant-design#2506) docs: improve Progress api doc Update index.zh-CN.md (ant-design#2494) lint: fix ts error in @types/react-native-drawer-layout chore: fix test error build: delete cdn-tools in deploy cmd demo: add dynamic child demo to Carousel, ref ant-design#2434 demo: improve Carousel demo docs: add change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is