Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: style of <SearchBar/> #2510

Merged
merged 1 commit into from May 4, 2018

Conversation

micooz
Copy link
Contributor

@micooz micooz commented May 4, 2018

This commit force ".am-search-synthetic-ph" and ".am-search-clear"
to use "content-box" to prevent external style such as ".am-tabs" breaking
its box-sizing.

Refs: #2447

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

  • Make sure that you add at least one unit test for the bug which you had fixed.

This change is Reviewable

This commit force ".am-search-synthetic-ph" and ".am-search-clear"
to use "content-box" to prevent external style such as ".am-tabs" breaking
its box-sizing.
@ghost ghost assigned micooz May 4, 2018
@ghost ghost added the In Progress label May 4, 2018
@micooz micooz requested a review from KgTong May 4, 2018 06:33
@codecov
Copy link

codecov bot commented May 4, 2018

Codecov Report

Merging #2510 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2510   +/-   ##
======================================
  Coverage    58.4%   58.4%           
======================================
  Files         262     262           
  Lines        4565    4565           
  Branches     1289    1289           
======================================
  Hits         2666    2666           
  Misses       1894    1894           
  Partials        5       5
Flag Coverage Δ
#rn 60.29% <ø> (ø) ⬆️
#web 56.75% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f11560c...517d074. Read the comment docs.

@warmhug
Copy link
Contributor

warmhug commented May 4, 2018

测试没问题 自己合并吧。

@KgTong KgTong merged commit 1b01ef3 into ant-design:master May 4, 2018
@warmhug warmhug mentioned this pull request May 8, 2018
BANG88 added a commit to BANG88/ant-design-mobile that referenced this pull request May 11, 2018
* master:
  fix: Modal event close ant-design#2486
  fix(input-item): user experience regression on non-mutate control (ant-design#2537)
  fix(input-item): cursor dislocation when typing via system keyboard of UC browser (ant-design#2532)
  fix(Accordion): make aria-expanded prop valid in preact, close ant-design#2491 (ant-design#2530)
  fix(input-item): value.substring is not a function (ant-design#2508)
  demo: add use of listview component nested with tabbar, close ant-design#2455 (ant-design#2527)
  docs: improve List doc, close ant-design#2514
  docs: fix typo (ant-design#2523)
  fix: style of <SearchBar/> (ant-design#2510)
  fix: development error
  fix: upgrade rmc-feedback to 2.x (ant-design#2509)
  fix(textarea-item) close ant-design#2372 (ant-design#2506)
  docs: improve Progress api doc
  Update index.zh-CN.md (ant-design#2494)
  lint: fix ts error in @types/react-native-drawer-layout
  chore: fix test error
  build: delete cdn-tools in deploy cmd
  demo: add dynamic child demo to Carousel, ref ant-design#2434
  demo: improve Carousel demo
  docs: add change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants