Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(input-item): user experience regression on non-mutate control #2537

Merged
merged 1 commit into from May 11, 2018

Conversation

micooz
Copy link
Contributor

@micooz micooz commented May 11, 2018

PR #2532 会引起一个问题:在输入的内容中间插入或删除字符的时候,光标会被重置到末尾,体验很差。

该PR将区分对待 onChange 过程中可能会改变原始值的场景(bankCard、phone、number),对其他类型不做延迟 onChange

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

This change is Reviewable

@ghost ghost assigned micooz May 11, 2018
@ghost ghost added the In Progress label May 11, 2018
@KgTong KgTong merged commit 2274803 into ant-design:master May 11, 2018
BANG88 added a commit to BANG88/ant-design-mobile that referenced this pull request May 11, 2018
* master:
  fix: Modal event close ant-design#2486
  fix(input-item): user experience regression on non-mutate control (ant-design#2537)
  fix(input-item): cursor dislocation when typing via system keyboard of UC browser (ant-design#2532)
  fix(Accordion): make aria-expanded prop valid in preact, close ant-design#2491 (ant-design#2530)
  fix(input-item): value.substring is not a function (ant-design#2508)
  demo: add use of listview component nested with tabbar, close ant-design#2455 (ant-design#2527)
  docs: improve List doc, close ant-design#2514
  docs: fix typo (ant-design#2523)
  fix: style of <SearchBar/> (ant-design#2510)
  fix: development error
  fix: upgrade rmc-feedback to 2.x (ant-design#2509)
  fix(textarea-item) close ant-design#2372 (ant-design#2506)
  docs: improve Progress api doc
  Update index.zh-CN.md (ant-design#2494)
  lint: fix ts error in @types/react-native-drawer-layout
  chore: fix test error
  build: delete cdn-tools in deploy cmd
  demo: add dynamic child demo to Carousel, ref ant-design#2434
  demo: improve Carousel demo
  docs: add change
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants