rewrite in typescript #1846

yiminghe · 2016-05-25T09:09:56Z

https://www.typescriptlang.org/docs/handbook/basic-types.html

demo: https://github.com/ant-design/ant-design/blob/master/components/affix/index.tsx
recommended IDE: visual studio code / idea

steps

env

npm i typings -g
typings install

move types in index.d.ts to components/xx/index.tsx

change react import

import React from 'react';
import ReactDOM from 'react-dom';

to

import * as React from 'react';
import * as ReactDOM from 'react-dom';

add reference to components/index.tsx

import Xx from './xx';
export { Xx };

npm run ts-lint

delete index.d.ts

change index.js to

module.export = require('./src/');
console.warn('you are ....')

components

Make sure no tsc errors (Add tsc into npm run lint)
delete index.d.ts
change index.js to ...

This will close #973

The text was updated successfully, but these errors were encountered:

waywardmonkeys · 2016-06-06T03:08:09Z

Is this going to happen? (I think it would be great!)

yiminghe · 2016-06-22T08:14:01Z

affix ok

afc163 · 2016-06-22T09:38:51Z

Add https://github.com/buzinas/tslint-eslint-rules for missing eslint rules like object-curly-spacing

BANG88 · 2016-06-23T04:40:38Z

Maybe i can do something about this topic. but don't know your plan yet.

yiminghe · 2016-06-23T06:33:52Z

@BANG88 move types in index.d.ts to components , see affix, welcome pr

afc163 · 2016-06-23T09:01:21Z

Assigned and updated

afc163 · 2016-06-23T09:02:08Z

@BANG88 @waywardmonkeys Maybe you guys can help to rewrite some components which are assigned to you above. (If you want to 🎅 )

BANG88 · 2016-06-23T09:17:36Z

@afc163 OK.can we have a develop instruction? how to rewrite it using ts,and how to test it.
By the way, npm start failed on windows.

afc163 · 2016-06-23T09:23:00Z

Develop instruction: https://github.com/ant-design/ant-design/wiki/Development#local-development

And rewrite instruction in top floor: #1846 (comment)

We don't support developing in windows right now. 😢 You could help us improve that too.

BANG88 · 2016-06-23T13:12:44Z

@afc163 @yiminghe

I add some typings for Tabs.but not sure this is ok ?.can you have a look... Thanks
https://github.com/bang88/ant-design/commit/72965da807516c69c65a3a53379c96cc661aab27

RaoHai · 2016-06-24T07:23:58Z

3c4dec2

是这样改的么？总感觉哪里不对的样子

yiminghe · 2016-06-24T15:26:35Z

after modification, use vs code to open project and check

GrayChoi · 2016-06-26T05:07:21Z

我也可以帮忙用typescript重写一部分组件，如果需要的话。

dyf2015 · 2016-06-26T05:09:20Z

??ts?????????

???? iPhone

? 2016?6?26??13:07?Gray Choi <notifications@github.com mailto:notifications@github.com> ???

???????typescript???????????????

You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com//issues/1846#issuecomment-228584616, or mute the threadhttps://github.com/notifications/unsubscribe/APjvyTFgIjFcdvL6RkLzPbZdXuF5tj7pks5qPgkYgaJpZM4ImUZY.

maolion · 2016-06-29T07:55:13Z

赞!

maolion · 2016-06-29T07:58:48Z

我也可以帮忙，如果有需要的话。

afc163 · 2016-06-29T08:27:59Z

@GrayChoi @maolion Assigned some component to you, Thx!

maolion · 2016-06-29T08:41:43Z

@afc163 看到了，最近很少关注antd的动态。

infeng · 2016-06-29T09:37:40Z

i use typescript a long time, i can help

xuyang2 · 2016-07-01T09:55:56Z

我也可以帮忙用 TypeScript 改写一部分组件，如果需要的话。

benjycui · 2016-07-04T01:42:04Z

看来大家都是对写代码感兴趣，不喜欢写文档 😂

yeliex · 2016-07-09T08:31:51Z

@benjycui 我可以帮忙更新文档如果需要的话

benjycui · 2016-07-09T09:29:13Z

@yeliex THX, and see: #1471

benjycui · 2016-08-15T06:59:15Z

@wenxiongid if you have no time, I am going to finish your tasks, OK?

wenxiongid · 2016-08-15T09:18:57Z

@benjycui OK, sorry for my busy job these days

plandem · 2016-08-15T12:35:10Z

omg...looks like it's going to happen :)

benjycui · 2016-08-20T01:10:32Z

Jobs done ! @afc163 @benjycui @RaoHai @ddcat1115 @BANG88 @GrayChoi

But, there still leave a lot to be improved. 😄

afc163 · 2016-08-20T09:55:01Z

Updated.

benjycui · 2016-08-22T03:55:35Z

Make sure no tsc errors (Add tsc into npm run lint)

WIP

benjycui · 2016-08-25T01:42:31Z

change index.js to ...

@afc163 ??

afc163 · 2016-08-25T02:57:00Z

Look at #1846 (comment)

ziaochina · 2016-09-28T07:17:18Z

很想知道为啥要换TypeScript呢?

afc163 · 2016-09-28T07:21:53Z

@ziaochina #973

ziaochina · 2016-09-28T07:45:00Z

@afc163 除了#973,有微软方面的原因吗?

AlbertZheng · 2016-10-10T08:21:29Z

When migrated from antd 1.11.x to 2.0.1, there are many errors reported by tsc 1.8.10 and 2.0.3 as the following. Please have a check:

A workaround for TS7006 is to manually add any or any[] type declaration for those parameter in the reported d.ts files. But this error "TS2307: Cannot find module 'rc-select'" perhaps will need to write a index.d.ts for rc-select component.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/upload/interface.d.ts
(30,23): error TS7006: Parameter 'File' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/select/index.d.ts
(2,34): error TS2307: Cannot find module 'rc-select'.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/select/index.d.ts
(38,17): error TS7006: Parameter 'value' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/icon/index.d.ts
(5,16): error TS7006: Parameter 'e' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/form/Form.d.ts
(48,30): error TS7019: Rest parameter 'args' implicitly has an 'any[]' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/date-picker/index.d.ts
(11,29): error TS7006: Parameter 'trigger' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/breadcrumb/Breadcrumb.d.ts
(7,19): error TS7006: Parameter 'route' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/breadcrumb/Breadcrumb.d.ts
(7,26): error TS7006: Parameter 'params' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/breadcrumb/Breadcrumb.d.ts
(7,34): error TS7006: Parameter 'routes' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/breadcrumb/Breadcrumb.d.ts
(7,42): error TS7006: Parameter 'paths' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/back-top/index.d.ts
(4,16): error TS7006: Parameter 'event' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/alert/index.d.ts
(16,16): error TS7006: Parameter 'event' implicitly has an 'any' type.

ERROR in /home/vagrant/apps/r0/node_modules/antd/lib/auto-complete/index.d.ts
(24,17): error TS7006: Parameter 'value' implicitly has an 'any' type.

AlbertZheng · 2016-10-10T08:23:56Z

BTW, the four apis are missing in the d.ts file of notification component of antd 2.0.1 when migrated from antd 1.11.x to 2.0.1:

notification.success(config)
notification.error(config)
notification.info(config)
notification.warn(config)

lock · 2018-05-04T00:15:51Z

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

yiminghe added the 🕙 Plan label May 25, 2016

RaoHai mentioned this issue Jun 24, 2016

rewrite collapse in typescript #2167

Merged

BANG88 mentioned this issue Jun 26, 2016

Refactor typings #2177

Merged

5 tasks

benjycui mentioned this issue Jun 28, 2016

Typescript bindings for rc-slider react-component/slider#106

Closed

GrayChoi mentioned this issue Jul 1, 2016

rewrite in typescript #2246

Merged

8 tasks

afc163 mentioned this issue Jul 5, 2016

2.0 #1538

Closed

19 tasks

afc163 added a commit that referenced this issue Jul 12, 2016

Fix ts error in Affix (#1846)

ce7e7c7

RaoHai mentioned this issue Aug 11, 2016

rewrite form and dropdown in ts #2683

Merged

afc163 mentioned this issue Aug 16, 2016

npm run compile出错 #2730

Closed

benjycui mentioned this issue Aug 18, 2016

Refactor ts #2760

Merged

benjycui closed this as completed Aug 20, 2016

This was referenced Aug 20, 2016

fork了整个项目，本地执行npm run compile报错 #2787

Closed

Typescript Definition file missing things #2783

Closed

afc163 reopened this Aug 20, 2016

benjycui added a commit that referenced this issue Aug 25, 2016

chore: update index.js, close: #1846

12519d5

benjycui mentioned this issue Aug 25, 2016

chore: update index.js, close: #1846 #2838

Merged

afc163 closed this as completed in #2838 Aug 26, 2016

afc163 pushed a commit that referenced this issue Aug 26, 2016

chore: update index.js, close: #1846 (#2838)

4bfe8cb

afc163 mentioned this issue Aug 31, 2016

请问是否能提供最新的d.ts文件？用于在TypeScript中使用antd? #2901

Closed

benjycui mentioned this issue Sep 20, 2016

antd 2.0 changelog #3020

Closed

2 tasks

dxps mentioned this issue Sep 22, 2016

docs: update change log, close: #3020 #3087

Merged

afc163 mentioned this issue Sep 28, 2016

你们是否会考虑下 typescript 的支持呢 #973

Closed

lock bot locked as resolved and limited conversation to collaborators May 4, 2018

rewrite in typescript #1846

rewrite in typescript #1846

Comments

yiminghe commented May 25, 2016 • edited by benjycui Loading

steps

env

move types in index.d.ts to components/xx/index.tsx

change react import

add reference to components/index.tsx

npm run ts-lint

delete index.d.ts

change index.js to

components

waywardmonkeys commented Jun 6, 2016

yiminghe commented Jun 22, 2016

afc163 commented Jun 22, 2016

BANG88 commented Jun 23, 2016

yiminghe commented Jun 23, 2016

afc163 commented Jun 23, 2016

afc163 commented Jun 23, 2016 • edited Loading

BANG88 commented Jun 23, 2016

afc163 commented Jun 23, 2016 • edited Loading

BANG88 commented Jun 23, 2016

RaoHai commented Jun 24, 2016

yiminghe commented Jun 24, 2016

GrayChoi commented Jun 26, 2016

dyf2015 commented Jun 26, 2016

maolion commented Jun 29, 2016

maolion commented Jun 29, 2016

afc163 commented Jun 29, 2016 • edited Loading

maolion commented Jun 29, 2016

infeng commented Jun 29, 2016

xuyang2 commented Jul 1, 2016 • edited Loading

benjycui commented Jul 4, 2016

yeliex commented Jul 9, 2016

benjycui commented Jul 9, 2016

benjycui commented Aug 15, 2016

wenxiongid commented Aug 15, 2016

plandem commented Aug 15, 2016

benjycui commented Aug 20, 2016

afc163 commented Aug 20, 2016 • edited by benjycui Loading

benjycui commented Aug 22, 2016

benjycui commented Aug 25, 2016

afc163 commented Aug 25, 2016

ziaochina commented Sep 28, 2016

afc163 commented Sep 28, 2016

ziaochina commented Sep 28, 2016

AlbertZheng commented Oct 10, 2016 • edited Loading

AlbertZheng commented Oct 10, 2016

lock bot commented May 4, 2018

yiminghe commented May 25, 2016 •

edited by benjycui

Loading

afc163 commented Jun 23, 2016 •

edited

Loading

afc163 commented Jun 23, 2016 •

edited

Loading

afc163 commented Jun 29, 2016 •

edited

Loading

xuyang2 commented Jul 1, 2016 •

edited

Loading

afc163 commented Aug 20, 2016 •

edited by benjycui

Loading

AlbertZheng commented Oct 10, 2016 •

edited

Loading