Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Menu component animation #19602

Closed
1 task done
shaodahong opened this issue Nov 6, 2019 · 1 comment
Closed
1 task done

Improve Menu component animation #19602

shaodahong opened this issue Nov 6, 2019 · 1 comment
Assignees
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive

Comments

@shaodahong
Copy link
Member

shaodahong commented Nov 6, 2019

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

react-component/menu#297 (comment)

Steps to reproduce

menu

What is expected?

start the animation without previously hidden animation

What is actually happening?

with previously hidden animation

Environment Info
antd 3.25.0, 4.0
React 16.3
System Mac OS X
Browser chrome 75.0.3770.100
@shaodahong shaodahong added the improvement improve some features label Nov 6, 2019
@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Jun 1, 2020
@ant-design-bot
Copy link
Contributor

Hello @shaodahong. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. Appreciate it advance and we are looking forward to your contribution!

你好 @shaodahong, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献!

giphy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. improvement improve some features Inactive
Projects
None yet
Development

No branches or pull requests

4 participants