-
-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix trigger repeat animation #297
Conversation
This pull request is being automatically deployed with ZEIT Now (learn more). 🔍 Inspect: https://zeit.co/react-component/menu/8dkhh3j92 |
这样应该就可以了,popup 有自己的动画, |
Codecov Report
@@ Coverage Diff @@
## master #297 +/- ##
==========================================
- Coverage 93.74% 93.72% -0.02%
==========================================
Files 11 11
Lines 799 797 -2
Branches 229 229
==========================================
- Hits 749 747 -2
Misses 50 50
Continue to review full report at Codecov.
|
看看是不是应该在 |
和 |
V7 版本我刚才看了也是没有的,popupMotion 是 V8 刚加的 |
能给个重现看看吗?这个 motion 做兼容特地加的,我看看是我哪里疏忽了。 |
你看下这个 menu 的动画 ant-design/ant-design#19498 (comment) 这个得截图也是上面的例子 |
嗯,你是对的。我发个版看看效果。 |
|
如果 v3 也有,可以先放放。升级优先级更高些。 |
popupClassName={`${prefixCls}-popup ${popupClassName}`} | ||
popupClassName={classNames(`${prefixCls}-popup`, { | ||
[props.popupClassName]: | ||
props.mode !== 'inline' && props.popupClassName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上面的代码里把 popupClassName
删了,这里一直空的。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
……我说怎么一直都是 undefined, 所以我换成这个写法了,没看到,我修复下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
之前没用 classNames
所以我看到页面渲染出 undefined 就换成这个了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不用了,已经 patch 了
Ref: ant-design/ant-design#19498 (comment)