Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alert close button style #21324

Closed
1 task done
IndProgo opened this issue Feb 10, 2020 · 0 comments · Fixed by #21325
Closed
1 task done

alert close button style #21324

IndProgo opened this issue Feb 10, 2020 · 0 comments · Fixed by #21325
Assignees
@zombieJ
Labels
🐛 Bug Ant Design Team had proved that this is a bug.

Comments

@IndProgo
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Inspect close button for alert in browser's devtool

What is expected?

Normalized padding for the button element

What is actually happening?

Alert's close button has browser`s default padding and on Firefox button moves to side when pressed.

Environment Info
antd 3.26.9
React 16
System windows
Browser firefox, chrome, edge
@zombieJ zombieJ added the 🐛 Bug Ant Design Team had proved that this is a bug. label Feb 10, 2020
@zombieJ zombieJ self-assigned this Feb 10, 2020
afc163 added a commit that referenced this issue Feb 10, 2020
@afc163
🐛 fix Alert button extra padding in Firefox
ce378a2 
close #21324
@afc163 afc163 mentioned this issue Feb 10, 2020
Merged
14 tasks
@zombieJ zombieJ mentioned this issue Feb 10, 2020
Closed
14 tasks
afc163 added a commit that referenced this issue Feb 10, 2020
@afc163
🐛 fix Alert button extra padding in Firefox (#21325)
3e8be5b 
close #21324
afc163 added a commit that referenced this issue Feb 10, 2020
@afc163
🐛 fix Alert button extra padding in Firefox (#21325)
f692e7e 
close #21324
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
🐛 Bug Ant Design Team had proved that this is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Alert button extra padding ant-design/ant-design
2 participants
@zombieJ @IndProgo