Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rtl.less for all components #22239

Closed
43 tasks done
xrkffgg opened this issue Mar 16, 2020 · 18 comments
Closed
43 tasks done

Add rtl.less for all components #22239

xrkffgg opened this issue Mar 16, 2020 · 18 comments
Labels
improvement improve some features rtl

Comments

@xrkffgg
Copy link
Member

xrkffgg commented Mar 16, 2020

What problem does this feature solve?

In order to better find、locate、and solve problems, now plan to split the rtl style in all components into rtl.less.

This is a huge and tedious project, but it also makes sense.

If I'm free, I will fix it one by one. 😏

If you are interested and have time, welcome to PR.

If you decide to start an unfinished component, please comment your chose in the following comments. Thank you.

  • You must be more careful or you will make mistakes.

  • If you think you've done it, you must check it more than three times.


Before

components


  • Checkbox Cascader 4.0.3
  • else 4.0.4

Only the split PR and repair split PR are listed here.

COM FS V UNL V FCS V
Button #22252 #22260 4.0.4 #22384 4.0.4 - -
Typography #22252 4.0.4 #22384 4.0.4 - -
Grid #22252 4.0.4 #22384 4.0.4 - -
Breadcrumb #22258 4.0.4 #22384 4.0.4 - -
Dropdown #22258 4.0.4 #22384 4.0.4 - -
Menu #22271 4.0.4 #22384 4.0.4 - -
Pagination #22271 4.0.4 #22384 4.0.4 - -
PageHeader #22271 4.0.4 #22384 4.0.4 - -
Steps #22290 4.0.4 #22384 4.0.4 #22523 4.1.0
Checkbox #22186 4.0.3 #22384 4.0.4 - -
Cascader #22191 4.0.3 - - - -
DatePicker #22414 4.0.4 - - - -
Form #22389 4.0.4 - - - -
Input #22399 4.0.4 - - #22525 4.1.0
Rate #22294 4.0.4 #22384 4.0.4 - -
Radio #22405 4.0.4 - - - -
Switch #22294 4.0.4 #22384 4.0.4 - -
Slider #22294 4.0.4 #22384 4.0.4 - -
Select #22307 4.0.4 #22384 4.0.4 - -
Transfer #22307 4.0.4 #22384 4.0.4 - -
Upload #22307 4.0.4 #22384 4.0.4 - -
Badge #22320 4.0.4 #22384 4.0.4 #22551 4.1.0
Comment #22320 4.0.4 #22384 4.0.4 - -
Collapse #22320 4.0.4 #22384 4.0.4 - -
Carousel #22330 4.0.4 #22384 4.0.4 - -
Descriptions #22330 4.0.4 #22384 4.0.4 - -
Empty #22330 4.0.4 #22384 4.0.4 - -
List #22331 4.0.4 #22384 4.0.4 - -
Popover #22331 4.0.4 - - - -
Statistic #22331 4.0.4 - - - -
Tree #22335 4.0.4 - - - -
Tooltip #22335 4.0.4 - - - -
Timeline #22335 4.0.4 - - - -
Tag #22339 4.0.4 - - - -
Tabs #22339 4.0.4 - - - -
Table #22402 4.0.4 - - - -
Alert #22339 4.0.4 - - - -
Drawer #22354 4.0.4 #22384 4.0.4 - -
Modal #22354 4.0.4 #22384 4.0.4 - -
Progress #22354 4.0.4 #22384 4.0.4 #22509 | #22558 4.0.4 | 4.1.0
Result #22354 4.0.4 #22384 4.0.4 - -
Spin #22388 4.0.4 - - - -
Skeleton #22388 4.0.4 - - - -
@yoyo837
Copy link
Contributor

yoyo837 commented Mar 16, 2020

可以参照 #19380 的列表

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 16, 2020

写了一半了,我还是对照网站和代码吧 😂😂,有的模块没有 rtl

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 17, 2020

  • Radio components are not recommended for splitting at this time.

Radio.Group Button style exception found after split

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 17, 2020

Form Input Skip first

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 17, 2020

  • DatePicker local may have an effect on splitting rtl.less

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 18, 2020

🤩🤩🤩

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 18, 2020

@afc163 明天我把所有组件的 rtl.less 检查一遍,把引用方式都 统一。

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 19, 2020

rtl.less Name and Location requirements

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 19, 2020

  • BackTop almost unchanged, so stay as it is

@afc163
Copy link
Member

afc163 commented Mar 19, 2020

Is Rate waiting for react-component/rate#54 ?

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 19, 2020

When it is done, I'll check the Rate again.

@yoyo837
Copy link
Contributor

yoyo837 commented Mar 20, 2020

顺手加个?
issue: #22420

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 20, 2020

InputNumber 之前没有,我等这些都确定了,再弄这个

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 20, 2020

All components has done.

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 20, 2020

The rest is to add new or repair.

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 23, 2020

Fix Progress RTL #22509

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 23, 2020

rtl.less 拆分( css 顺序)引起的样式异常修复:

@xrkffgg
Copy link
Member Author

xrkffgg commented Mar 24, 2020

@afc163 @zombieJ
I have update the description, you can see this information more clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement improve some features rtl
Projects
None yet
Development

No branches or pull requests

3 participants