Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamic hide and display steps not working #24627

Closed
1 task
israelKusayev opened this issue May 31, 2020 · 3 comments · Fixed by react-component/steps#110 or #24644
Closed
1 task

Dynamic hide and display steps not working #24627

israelKusayev opened this issue May 31, 2020 · 3 comments · Fixed by react-component/steps#110 or #24644
Assignees
@zombieJ
Labels
improvement improve some features 👷🏻‍♂️ Someone working on it

Comments

@israelKusayev
Copy link
Contributor

israelKusayev commented May 31, 2020 •
edited
Loading

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Click on the button

What is expected?

extra steps should appear

What is actually happening?

extra steps don't appear

Environment Info
antd 4.3.0
React 16.13.1
System windows 10
Browser chrome 83
@zombieJ
Copy link
Member

zombieJ commented Jun 1, 2020 •
edited
Loading

Steps not support Fragment.

https://codesandbox.io/s/antd-reproduction-template-cipnh?file=/steps.jsx

@zombieJ zombieJ added the improvement improve some features label Jun 1, 2020
@zombieJ zombieJ self-assigned this Jun 1, 2020
@zombieJ zombieJ mentioned this issue Jun 1, 2020
Merged
@zombieJ zombieJ reopened this Jun 1, 2020
@zombieJ zombieJ mentioned this issue Jun 1, 2020
Merged
17 tasks
@israelKusayev
Copy link
Contributor Author

@zombieJ thank you it is working good, but when I'm using React.Fragment I get an error about the keys in browser console

image

@zombieJ
Copy link
Member

zombieJ commented Jun 16, 2020

Hi @israelKusayev , pls check key if duplicated. If not, could you help to create a new issue about this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zombieJ zombieJ

Labels
improvement improve some features 👷🏻‍♂️ Someone working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Use father & rc-util react-component/steps
chore: Steps children ant-design/ant-design
2 participants
@zombieJ @israelKusayev