-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
改进Table的DataIndex的类型 #27997
Comments
Hello @heroboy. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution! 你好 @heroboy, 我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献! |
|
@zombieJ |
我再补充2点。
|
|
没完全看懂你(@zombieJ)在说什么。 |
噗,我想当然了。sorry |
What problem does this feature solve?
现在DataIndex的定义是这样的:
我建议改成
那样在定义columns的时候,输入
{ dataIndex:'
立刻就有智能提示了。当然后面的number | (string | number)[]
要改成强类型的话,写起来就比较复杂了。像上面这样改是最常用的情况,是最简单的,效果也能立竿见影。
你们一开始写成这样,大概是因为以前版本支持
'user.age'
这种写法吧。现在不支持了。类似其它的Form里的NameList,Table的rowKey,以及其它我还没用到过的等等等等,也一并这样建议。
What does the proposed API look like?
type DataIndex = keyof RecordType | number | (string | number)[];
The text was updated successfully, but these errors were encountered: