Skip to content

croe: imporve dataIndex type#717

Closed
alpacachen wants to merge 1 commit into
react-component:masterfrom
alpacachen:master
Closed

croe: imporve dataIndex type#717
alpacachen wants to merge 1 commit into
react-component:masterfrom
alpacachen:master

Conversation

@alpacachen
Copy link
Copy Markdown

@vercel
Copy link
Copy Markdown

vercel Bot commented Dec 20, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/table/Deztf6CGpWNY3M9WDoVoj5iRiRCG
✅ Preview: https://table-git-fork-alpacachen-master-react-component.vercel.app

@alpacachen
Copy link
Copy Markdown
Author

有个问题想要请教一下,context使用泛型是否有意义?

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 20, 2021

Codecov Report

Merging #717 (0f23396) into master (dc08f13) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #717   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          33       33           
  Lines         958      958           
  Branches      290      277   -13     
=======================================
  Hits          955      955           
  Misses          3        3           
Impacted Files Coverage Δ
src/Cell/index.tsx 98.95% <ø> (ø)
src/FixedHolder/index.tsx 100.00% <100.00%> (ø)
src/context/BodyContext.tsx 100.00% <100.00%> (ø)
src/utils/valueUtil.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc08f13...0f23396. Read the comment docs.

@afc163 afc163 requested a review from zombieJ December 20, 2021 13:05
@alpacachen
Copy link
Copy Markdown
Author

@zombieJ 请帮忙cr一下,看了下历史issue,感觉还挺多人需要这个的

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants