Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Styles doesn't apply correctly on notification opened by useNotification hook #30576

Closed
1 task done
myxious opened this issue May 18, 2021 · 0 comments · Fixed by #30588
Closed
1 task done

Styles doesn't apply correctly on notification opened by useNotification hook #30576

myxious opened this issue May 18, 2021 · 0 comments · Fixed by #30588
Assignees
@afc163
Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it

Comments

@myxious
Copy link

myxious commented May 18, 2021

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Pass className or style to api.open with changing notification width.

What is expected?

The notification takes the given width.

What is actually happening?

The notification width is overlapped by the parent element with .ant-notification-hook-holder class.

Environment Info
antd 4.15.6
React 17.0.2
System Windows 10
Browser Chrome 90.0.4430.212

Regular notification call without a hook works properly.
@afc163 afc163 added 🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it labels May 18, 2021
@afc163 afc163 self-assigned this May 19, 2021
afc163 added a commit that referenced this issue May 19, 2021
@afc163
fix: useNotification className should work
81942d2 
close #30576
@afc163 afc163 mentioned this issue May 19, 2021
Merged
19 tasks
afc163 added a commit that referenced this issue May 19, 2021
@afc163
fix: useNotification className should work
2303a06 
close #30576
afc163 added a commit that referenced this issue May 19, 2021
@afc163
fix: useNotification className should work (#30588)
f3d5470 
close #30576
afc163 added a commit that referenced this issue May 24, 2021
@afc163 @zjffun
@zombieJ @kerm1it @chenshuai2144
style: new design table header action (#30406)
a09bf5f 
* docs(:sparkles:): release 4.15.6 (#30562)

* fix(Collapse): end motion when set activeKey while hiding (#30555)

* docs: update changelog

* fix: Typography ellipsis flush when contain suffix (#30582)

* fix: Typography ellipsis flush when contain suffix

* update snapshot

* fix Text default rows

* fix Text default rows

* style: refactor Collapse arrow style (#30586)

close #30585

* fix: nested Table margin inside table with fixed columns (#30587)

close #30564

* fix: useNotification className should work (#30588)

close #30576

* fix: Space missing TS def (#30590)

* docs: Update Transfer asnyc table demo
close #30350

* fix: Anchor should trigger onChange when have getCurrentAnchor (#30601)

* fix: Anchor should trigger onChange when have getCurrentAnchor

close #30584

* test: add test case

* chore: Thanks @yesmeck & @ycjcl868 (#30618)

* chore(config-provider): support dynamic prefixCls (#30625)

* feat: improve Table filter and sorter position

* fix: edge cases of th border

* fix lint

* style: apply new design

* fix css detail

* fix stylelint

* fix css error

* style: sorter icon hover color

* fix test cases

* update snapshot

* fix th padding

* fix calc

Co-authored-by: JuFeng Zhang <zjffun@gmail.com>
Co-authored-by: 二货机器人 <smith3816@gmail.com>
Co-authored-by: Kermit <kermitlx@outlook.com>
Co-authored-by: chenshuai2144 <qixian.cs@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afc163 afc163

Labels
🐛 Bug Ant Design Team had proved that this is a bug. 👷🏻‍♂️ Someone working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: useNotification className should work correctly ant-design/ant-design
2 participants
@afc163 @myxious