Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: new design table header action #30406

Merged
merged 25 commits into from
May 24, 2021
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented May 6, 2021

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

图片

before ✅ after
图片 图片
before ✅ after
图片 图片

📝 Changelog

Language Changelog
🇺🇸 English Redsign Table filter and sorter buttons to clearify current column.
🇨🇳 Chinese 重新设计 Table 筛选和排序按钮的位置,使其归属列更明确。

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

@afc163 afc163 changed the base branch from master to feature May 6, 2021 05:12
@afc163 afc163 force-pushed the new-design-table-header-action branch 2 times, most recently from 29bcd05 to 5e7d933 Compare May 6, 2021 05:12
@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2021

Size Change: -219 B (0%)

Total Size: 848 kB

Filename Size Change
./dist/antd-with-locales.min.js 349 kB -32 B (0%)
./dist/antd.compact.min.css 63.9 kB -62 B (0%)
./dist/antd.dark.min.css 65.2 kB -42 B (0%)
./dist/antd.min.css 63.9 kB -46 B (0%)
./dist/antd.min.js 306 kB -37 B (0%)

compressed-size-action

@afc163 afc163 force-pushed the new-design-table-header-action branch from 3fad91b to bbae99b Compare May 6, 2021 08:31
@codecov
Copy link

codecov bot commented May 6, 2021

Codecov Report

Merging #30406 (0eb5274) into feature (b135ae1) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #30406   +/-   ##
========================================
  Coverage    99.98%   99.98%           
========================================
  Files          397      397           
  Lines         7544     7544           
  Branches      2111     2111           
========================================
  Hits          7543     7543           
  Misses           1        1           
Impacted Files Coverage Δ
...omponents/table/hooks/useFilter/FilterDropdown.tsx 100.00% <100.00%> (ø)
components/table/hooks/useSorter.tsx 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b135ae1...0eb5274. Read the comment docs.

@afc163 afc163 force-pushed the new-design-table-header-action branch from d68ab73 to ed92af7 Compare May 7, 2021 09:43
@afc163 afc163 marked this pull request as ready for review May 19, 2021 11:08
@afc163 afc163 force-pushed the new-design-table-header-action branch from ed92af7 to c33ce01 Compare May 19, 2021 11:08
@afc163
Copy link
Member Author

afc163 commented May 20, 2021

done!

@afc163 afc163 force-pushed the new-design-table-header-action branch from 1e44984 to 35869e7 Compare May 24, 2021 08:27
@afc163 afc163 merged commit a09bf5f into feature May 24, 2021
@afc163 afc163 deleted the new-design-table-header-action branch May 24, 2021 10:51
afc163 added a commit that referenced this pull request May 24, 2021
@afc163 afc163 restored the new-design-table-header-action branch May 24, 2021 10:58
@afc163 afc163 deleted the new-design-table-header-action branch May 25, 2021 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants