Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal.method() not trigger focus after close. #32923

Closed
1 task
joseAAlexandre opened this issue Nov 17, 2021 · 4 comments
Closed
1 task

Modal.method() not trigger focus after close. #32923

joseAAlexandre opened this issue Nov 17, 2021 · 4 comments
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@joseAAlexandre
Copy link

  • I have searched the issues of this repository and believe that this is not a duplicate.

Reproduction link

Edit on CodeSandbox

Steps to reproduce

Close the modal.method() not return to its previous focus.
Close the Modal return to the previous focus.

What is expected?

Both should return to its previous focus

What is actually happening?

Modal.method() is not focus after close.

Environment Info
antd 4.16.13
React 17.0.2
System Windows 7
Browser Microsoft Edge Versão 95.0.1020.53 (Compilação oficial) (64 bits)

To prevent default behavior changes add focusTriggerAfterClose on the Modal.method() is a good option.

@afc163 afc163 added the help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. label Nov 18, 2021
@github-actions
Copy link
Contributor

Hello @joseAAlexandre. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @joseAAlexandre,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@ElvisUpUp
Copy link

@afc163 我在尝试解决该issue时,发现该问题源自于ActionButton里的autofocus与rc-dialog里自动聚焦的逻辑相冲突,不知道是要从这两者中的哪一方去做兼容呢?

@joseAAlexandre
Copy link
Author

Any news?

@joseAAlexandre
Copy link
Author

@afc163 the fix commit cannot be approved?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Development

No branches or pull requests

3 participants