Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade rc-dialog and fix Modal animation #38275

Merged
merged 2 commits into from Oct 30, 2022
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Oct 30, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

close #36911
close #38232
close #27921
close #32923

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English - Fix Modal animation flush issue in React 18.
- Fix Modal.method() not focus trigger after close.
🇨🇳 Chinese - 修复在 React 18 下 Modal 动画闪烁的问题。
- 修复 Modal.method() 关闭时默认没有聚焦触发元素的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Oct 30, 2022

Size Change: 0 B

Total Size: 962 kB

ℹ️ View Unchanged
Filename Size
./dist/antd-with-locales.min.js 374 kB
./dist/antd.compact.min.css 67.6 kB
./dist/antd.dark.min.css 68.9 kB
./dist/antd.min.css 67.6 kB
./dist/antd.min.js 316 kB
./dist/antd.variable.min.css 68.2 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (237e8c4) compared to base (4522340).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #38275   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          446       446           
  Lines         8292      8292           
  Branches      2519      2519           
=========================================
  Hits          8292      8292           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 mentioned this pull request Oct 30, 2022
19 tasks
@afc163
Copy link
Member Author

afc163 commented Oct 30, 2022

图片

首次几乎必挂。。

@afc163 afc163 merged commit 9f8e43d into feature Oct 30, 2022
@afc163 afc163 deleted the fix/upgrade-rc-dialog branch October 30, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants