Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table -> Expandable row table header is rendered as td and has no top left border radius #39769

Closed
marekPrzybylakSof opened this issue Dec 23, 2022 · 1 comment · Fixed by #39781
Closed

Table -> Expandable row table header is rendered as td and has no top left border radius #39769

marekPrzybylakSof opened this issue Dec 23, 2022 · 1 comment · Fixed by #39781

Comments

@marekPrzybylakSof
Copy link

marekPrzybylakSof commented Dec 23, 2022 •
edited

Reproduction link

https://ant.design/components/table

Steps to reproduce

Even in official docs this bug is visible.

What is expected?

Bugfix to render <td> as <th>

What is actually happening?

In Table -> Expandable row version first <th> is rendered as <td> so CSS is not following this rule:

:where(.css-dev-only-do-not-override-19mkp0n).ant-table-wrapper .ant-table-container table>thead>tr:first-child th:first-child {
    border-start-start-radius: 8px;
}

Screenshot 2022-12-23 at 11 29 12

Environment Info
antd 5.1.0
React 18.2.0
System MacOs Ventura 13.1
Browser Chrome 108.0.5359.124 (Official Build) (x86_64)
@chunsch
Copy link
Contributor

chunsch commented Dec 24, 2022

render <td> because a11y: react-component/table#859, let me fix it.

chunsch added a commit to chunsch/ant-design that referenced this issue Dec 24, 2022
@chunsch
fix: expandable row table header is rendered as td and has no top lef…
539a54c 
…t border radius ant-design#39769
@chunsch chunsch mentioned this issue Dec 24, 2022
Merged
20 tasks
afc163 pushed a commit that referenced this issue Dec 24, 2022
@chunsch
fix: table expandable row header has no top left border radius (#39781)
056dabc 
* fix: expandable row table header is rendered as td and has no top left border radius #39769

* test: update expandIconColumnIndex
foryuki pushed a commit to foryuki/ant-design that referenced this issue Dec 24, 2022
@chunsch
fix: table expandable row header has no top left border radius (ant-d…
9d671ed 
…esign#39781)

* fix: expandable row table header is rendered as td and has no top left border radius ant-design#39769

* test: update expandIconColumnIndex
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: table expandable row header has no top left border radius chunsch/ant-design
2 participants
@chunsch @marekPrzybylakSof