-
Notifications
You must be signed in to change notification settings - Fork 572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds ability to define a scope #859
Conversation
update README.md add colgroup example combine two scope examples
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@afc163 Can we get this merged too please? |
Codecov Report
@@ Coverage Diff @@
## master #859 +/- ##
=======================================
Coverage 99.41% 99.41%
=======================================
Files 36 36
Lines 1017 1022 +5
Branches 304 307 +3
=======================================
+ Hits 1011 1016 +5
Misses 6 6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@zombieJ It seems to me that CI has started to fail, but this is not due to my changes |
And I think the problem is somewhere in |
Please check CI. |
OK. Let me handle this~ |
Update #891 |
Please help to create PR on antd also : ) |
In this PR I added:
colScope
androwScope
props to the table columns;Screenshot
So, by adding these props, we give developers an ability to improve accessibility in cases where the browser incorrectly determines the header cell type. And this, combined with other fixes, can help users with a screen reader to better understand and navigate through tables.
Examples that describe this a11y topic in more detail: Simple table, Table with two-level header
Without the scope attribute, tables that use rc-table may not meet the WCAG 1.3.1 success criteria.
Ref: https://www.w3.org/TR/WCAG20-TECHS/F91.html