Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

表格列在搜索情况下,国际化失效 #48110

Closed
nqsjd178559344 opened this issue Mar 27, 2024 · 3 comments · Fixed by #48126
Closed

表格列在搜索情况下,国际化失效 #48110

nqsjd178559344 opened this issue Mar 27, 2024 · 3 comments · Fixed by #48126
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. unconfirmed

Comments

@nqsjd178559344
Copy link

Reproduction link

Edit on CodeSandbox

Steps to reproduce

  1. 展开搜索项 2. 搜索111 3. 显示NOT FOUND

What is expected?

国际化显示正确

What is actually happening?

国际化显示错误

Environment Info
antd 5.13.0
React 18.2.0
System windows
Browser 123.0.6312.86(正式版本) (64 位)
@nqsjd178559344
Copy link
Author

操作如图
image

@afc163 afc163 added help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. 🐛 Bug Ant Design Team had proved that this is a bug. labels Mar 27, 2024
Copy link
Contributor

Hello @nqsjd178559344. We totally like your proposal/feedback, welcome to send us a Pull Request for it. Please send your Pull Request to proper branch (feature branch for the new feature, master for bugfix and other changes), fill the Pull Request Template here, provide changelog/TypeScript/documentation/test cases if needed and make sure CI passed, we will review it soon. We appreciate your effort in advance and looking forward to your contribution!

你好 @nqsjd178559344,我们完全同意你的提议/反馈,欢迎直接在此仓库 创建一个 Pull Request 来解决这个问题。请将 Pull Request 发到正确的分支(新特性发到 feature 分支,其他发到 master 分支),务必填写 Pull Request 内的预设模板,提供改动所需相应的 changelog、TypeScript 定义、测试用例、文档等,并确保 CI 通过,我们会尽快进行 Review,提前感谢和期待您的贡献。

giphy

@LingJinT
Copy link
Contributor

let me try

LingJinT added a commit to LingJinT/ant-design that referenced this issue Mar 27, 2024
afc163 added a commit that referenced this issue Mar 29, 2024
…ls when searching (#48126)

* fix: 表格列在搜索情况下,国际化失效 #48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
CooperHash pushed a commit to CooperHash/ant-design that referenced this issue Mar 29, 2024
…ls when searching (ant-design#48126)

* fix: 表格列在搜索情况下,国际化失效 ant-design#48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
CooperHash pushed a commit to CooperHash/ant-design that referenced this issue Mar 29, 2024
…ls when searching (ant-design#48126)

* fix: 表格列在搜索情况下,国际化失效 ant-design#48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
li-jia-nan pushed a commit that referenced this issue Apr 1, 2024
* fix: 表格列在搜索情况下,国际化失效 #48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

* fix: update table.filter test case

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
CooperHash pushed a commit to CooperHash/ant-design that referenced this issue Apr 10, 2024
…ls when searching (ant-design#48126)

* fix: 表格列在搜索情况下,国际化失效 ant-design#48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
CooperHash pushed a commit to CooperHash/ant-design that referenced this issue Apr 10, 2024
* fix: 表格列在搜索情况下,国际化失效 ant-design#48110

* Update components/table/hooks/useFilter/FilterDropdown.tsx

Co-authored-by: afc163 <afc163@gmail.com>
Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>

* fix: 补充测试用例

* fix: update table.filter test case

---------

Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
Co-authored-by: l2015 <lingjt@dtdream.com>
Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Ant Design Team had proved that this is a bug. help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. unconfirmed
Projects
None yet
3 participants