fix: Fixed the problem that internationalization of table columns fails when searching #48126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
👁 Visual Regression Report for PR #48126 Passed ✅
🎊 Congrats! No visual-regression diff found. 
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #48126 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 736 736
Lines 12684 12690 +6
Branches 3326 3329 +3
=========================================
+ Hits 12684 12690 +6 ☔ View full report in Codecov by Sentry. |
afc163
reviewed
Mar 27, 2024
|
pr title 需要用英文 |
afc163
reviewed
Mar 27, 2024
需要测试用例。 |
LingJinT
changed the title
LingJinT
changed the title
|
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com>
afc163
approved these changes
Mar 29, 2024
|
🎉 Thank you for your contribution! If you have not yet joined our DingTalk community group, please feel free to join us (when joining, please provide the link to this PR). 🎉 感谢您的贡献！如果您还没有加入钉钉社区群，请扫描下方二维码加入我们（加群时请提供此 PR 链接）。 
|
crazyair
reviewed
Mar 29, 2024
| @@ -2079,6 +2079,44 @@ describe('Table.filter', () => { | |||
| fireEvent.change(container.querySelector('.ant-input')!, { target: { value: '111' } }); | |||
| }); | |||
|
|
|||
| it('renders empty element when search not found', () => { | |||
| jest.spyOn(console, 'error').mockImplementation(() => undefined); | |||
CooperHash
pushed a commit
to CooperHash/ant-design
that referenced
this pull request
Mar 29, 2024
…ls when searching (ant-design#48126) * fix: 表格列在搜索情况下，国际化失效 ant-design#48110 * Update components/table/hooks/useFilter/FilterDropdown.tsx Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> * fix: 补充测试用例 --------- Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> Co-authored-by: l2015 <lingjt@dtdream.com> Co-authored-by: afc163 <afc163@gmail.com>
CooperHash
pushed a commit
to CooperHash/ant-design
that referenced
this pull request
Mar 29, 2024
…ls when searching (ant-design#48126) * fix: 表格列在搜索情况下，国际化失效 ant-design#48110 * Update components/table/hooks/useFilter/FilterDropdown.tsx Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> * fix: 补充测试用例 --------- Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> Co-authored-by: l2015 <lingjt@dtdream.com> Co-authored-by: afc163 <afc163@gmail.com>
CooperHash
pushed a commit
to CooperHash/ant-design
that referenced
this pull request
Apr 10, 2024
…ls when searching (ant-design#48126) * fix: 表格列在搜索情况下，国际化失效 ant-design#48110 * Update components/table/hooks/useFilter/FilterDropdown.tsx Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> * fix: 补充测试用例 --------- Signed-off-by: LingJinT <63446949+LingJinT@users.noreply.github.com> Co-authored-by: l2015 <lingjt@dtdream.com> Co-authored-by: afc163 <afc163@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #48110
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge