New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type for placeholder in select component #10282

Merged
merged 1 commit into from Apr 27, 2018

Conversation

Projects
None yet
3 participants
@thomasthiebaud
Contributor

thomasthiebaud commented Apr 27, 2018

First of all, thank you for your contribution! :-)

Please makes sure that these checkboxes are checked before submitting your PR, thank you!

  • Make sure that you propose PR to right branch: bugfix for master, feature for latest active branch feature-x.x.
  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

In the documentation, the placeholder can be string | ReactNode but not in the code. This PR update the type definition to include string and ReactNode

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 27, 2018

Deploy preview for ant-design ready!

Built with commit a4d0209

https://deploy-preview-10282--ant-design.netlify.com

@yesmeck yesmeck merged commit a1e186b into ant-design:master Apr 27, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No dependency changes
Details

@thomasthiebaud thomasthiebaud deleted the thomasthiebaud:fix-types branch Apr 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment