Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upFix type for placeholder in select component #10282
Conversation
This comment has been minimized.
This comment has been minimized.
ant-design-bot
commented
Apr 27, 2018
|
Deploy preview for ant-design ready! Built with commit a4d0209 |
yesmeck
merged commit a1e186b
into
ant-design:master
Apr 27, 2018
thomasthiebaud
deleted the
thomasthiebaud:fix-types
branch
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
thomasthiebaud commentedApr 27, 2018
First of all, thank you for your contribution! :-)
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.In the documentation, the placeholder can be
string | ReactNodebut not in the code. This PR update the type definition to includestringandReactNode