Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 3.4.4 #10296

Merged
merged 4 commits into from
Apr 28, 2018
Merged

Release 3.4.4 #10296

merged 4 commits into from
Apr 28, 2018

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Apr 28, 2018

For #10293

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 28, 2018

Deploy preview for ant-design ready!

Built with commit b6a617f

https://deploy-preview-10296--ant-design.netlify.com

@afc163 afc163 mentioned this pull request Apr 28, 2018
@codecov
Copy link

codecov bot commented Apr 28, 2018

Codecov Report

Merging #10296 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10296      +/-   ##
==========================================
+ Coverage   86.46%   86.68%   +0.22%     
==========================================
  Files         196      196              
  Lines        4779     4866      +87     
  Branches     1336     1375      +39     
==========================================
+ Hits         4132     4218      +86     
- Misses        644      645       +1     
  Partials        3        3
Impacted Files Coverage Δ
components/upload/utils.tsx 46.15% <ø> (ø) ⬆️
components/upload/Upload.tsx 76.57% <ø> (ø) ⬆️
components/badge/index.tsx 95.83% <0%> (-0.6%) ⬇️
components/timeline/Timeline.tsx 100% <0%> (ø) ⬆️
components/timeline/TimelineItem.tsx 100% <0%> (ø) ⬆️
components/list/index.tsx 98.18% <0%> (+0.74%) ⬆️
components/input/Search.tsx 87.87% <0%> (+1.21%) ⬆️
components/message/index.tsx 88.4% <0%> (+4.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b64882...b6a617f. Read the comment docs.

@afc163 afc163 merged commit 4956dd8 into master Apr 28, 2018
@afc163 afc163 deleted the release-3.4.4 branch April 28, 2018 07:36
@ghost
Copy link

ghost commented Apr 30, 2018

@afc163 please, review file components/upload/interface.tsx

"lastModrcFlieifiedDate" should be "lastModifiedDate"

@afc163
Copy link
Member Author

afc163 commented Apr 30, 2018

@danielg2002 Thx for reporting, a pull request will be nicer though~

@ghost
Copy link

ghost commented Apr 30, 2018

@afc163 #10315

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants