Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade menu #10305

Merged
merged 2 commits into from
Apr 29, 2018
Merged

chore: upgrade menu #10305

merged 2 commits into from
Apr 29, 2018

Conversation

picodoth
Copy link
Contributor

No description provided.

@@ -751,6 +751,7 @@ exports[`renders ./components/layout/demo/side.md correctly 1`] = `
class="ant-menu-submenu-arrow"
/>
</div>
<div />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多一个空 div 的意义是?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@afc163
Copy link
Member

afc163 commented Apr 28, 2018

PR 发到 master 就好,feature-3.5.0 已经合并到 master 了。

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Apr 28, 2018

Deploy preview for ant-design ready!

Built with commit 1abedef

https://deploy-preview-10305--ant-design.netlify.com

@afc163 afc163 changed the base branch from feature-3.5.0 to master April 28, 2018 15:06
@afc163
Copy link
Member

afc163 commented Apr 28, 2018

rebase 一下 master

@afc163
Copy link
Member

afc163 commented Apr 28, 2018

image

为啥这个库的邮箱老是没绑定上。

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch 6 times, most recently from 4193533 to e69428b Compare April 28, 2018 16:47
@afc163
Copy link
Member

afc163 commented Apr 28, 2018

value="on" 的问题确实有点奇怪。

@codecov
Copy link

codecov bot commented Apr 29, 2018

Codecov Report

Merging #10305 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10305      +/-   ##
==========================================
+ Coverage   86.46%   86.46%   +<.01%     
==========================================
  Files         196      196              
  Lines        4779     4780       +1     
  Branches     1336     1335       -1     
==========================================
+ Hits         4132     4133       +1     
  Misses        644      644              
  Partials        3        3
Impacted Files Coverage Δ
components/progress/progress.tsx 97.77% <100%> (+0.05%) ⬆️
components/table/filterDropdown.tsx 96.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6ad64...1abedef. Read the comment docs.

@afc163 afc163 merged commit 3a3d550 into master Apr 29, 2018
@afc163 afc163 deleted the feature-3.5.0-menu-fix branch April 29, 2018 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants