New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade menu #10305

Merged
merged 2 commits into from Apr 29, 2018

Conversation

Projects
None yet
3 participants
@picodoth
Contributor

picodoth commented Apr 28, 2018

No description provided.

@picodoth picodoth requested review from yesmeck, afc163 and yutingzhao1991 Apr 28, 2018

@@ -751,6 +751,7 @@ exports[`renders ./components/layout/demo/side.md correctly 1`] = `
class="ant-menu-submenu-arrow"
/>
</div>
<div />

This comment has been minimized.

@afc163

afc163 Apr 28, 2018

Member

多一个空 div 的意义是?

This comment has been minimized.

@afc163

This comment has been minimized.

Member

afc163 commented Apr 28, 2018

PR 发到 master 就好,feature-3.5.0 已经合并到 master 了。

@ant-design-bot

This comment has been minimized.

ant-design-bot commented Apr 28, 2018

Deploy preview for ant-design ready!

Built with commit 1abedef

https://deploy-preview-10305--ant-design.netlify.com

@afc163 afc163 changed the base branch from feature-3.5.0 to master Apr 28, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Apr 28, 2018

rebase 一下 master

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch from 0ab57c9 to d3b0a75 Apr 28, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Apr 28, 2018

image

为啥这个库的邮箱老是没绑定上。

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch 6 times, most recently from 4193533 to e69428b Apr 28, 2018

@afc163

This comment has been minimized.

Member

afc163 commented Apr 28, 2018

value="on" 的问题确实有点奇怪。

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch from e69428b to fa07dc9 Apr 28, 2018

@codecov

This comment has been minimized.

codecov bot commented Apr 29, 2018

Codecov Report

Merging #10305 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10305      +/-   ##
==========================================
+ Coverage   86.46%   86.46%   +<.01%     
==========================================
  Files         196      196              
  Lines        4779     4780       +1     
  Branches     1336     1335       -1     
==========================================
+ Hits         4132     4133       +1     
  Misses        644      644              
  Partials        3        3
Impacted Files Coverage Δ
components/progress/progress.tsx 97.77% <100%> (+0.05%) ⬆️
components/table/filterDropdown.tsx 96.55% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd6ad64...1abedef. Read the comment docs.

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch from fa07dc9 to 69b1a35 Apr 29, 2018

@picodoth picodoth force-pushed the feature-3.5.0-menu-fix branch from 69b1a35 to 04b0714 Apr 29, 2018

@afc163 afc163 force-pushed the feature-3.5.0-menu-fix branch from 88f454c to 1abedef Apr 29, 2018

@afc163 afc163 merged commit 3a3d550 into master Apr 29, 2018

6 checks passed

codecov/patch 100% of diff hit (target 86.46%)
Details
codecov/project 86.46% (+<.01%) compared to cd6ad64
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
deploy/netlify Deploy preview ready!
Details
security/snyk No new issues
Details

@afc163 afc163 deleted the feature-3.5.0-menu-fix branch Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment