Add promise-like interface #10470
Merged
Add promise-like interface #10470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhujinxuan
changed the title
|
Deploy preview for ant-design ready! Built with commit f5fe409 |
Codecov Report
@@ Coverage Diff @@
## feature-3.6.0 #10470 +/- ##
=================================================
+ Coverage 86.51% 87.85% +1.34%
=================================================
Files 196 194 -2
Lines 4798 4760 -38
Branches 1340 1329 -11
=================================================
+ Hits 4151 4182 +31
+ Misses 644 574 -70
- Partials 3 4 +1
Continue to review full report at Codecov.
|
zhujinxuan
changed the title
zhujinxuan
changed the title
zhujinxuan
force-pushed
the
message-promise
branch
from
4e1ad87
to
3db4e55
Compare
1 task
yesmeck
reviewed
May 15, 2018
| </div> | ||
| ), | ||
| onClose, | ||
| const closePromise = new Promise((resolve) => { |
There was a problem hiding this comment.
There was a problem hiding this comment.
I am not sure. Do you mean some browsers ant-design supporting does not support Promise?
yesmeck
reviewed
May 15, 2018
| // calculate the approximately duration value | ||
| const aboutDuration = parseInt((Date.now() - now) / 1000, 10); | ||
| expect(aboutDuration).toBe(defaultDuration); | ||
| done(); | ||
| }); | ||
| }).then(() => true); | ||
| }); |
There was a problem hiding this comment.
Fixed. Thank you.
afc163
reviewed
May 23, 2018
components/message/index.zh-CN.md
Outdated
| @@ -35,6 +35,12 @@ title: Message | |||
| - `message.config(options)` | |||
| - `message.destroy()` | |||
|
|
|||
| 组件同时提供 then 接口 | |||
afc163
reviewed
May 23, 2018
components/message/index.zh-CN.md
Outdated
| @@ -35,6 +35,12 @@ title: Message | |||
| - `message.config(options)` | |||
| - `message.destroy()` | |||
|
|
|||
| 组件同时提供 then 接口 | |||
| - `message[level](content, [duration] ).then(afterClose)` | |||
| - `message[level](content, [duration], onClose ).then(afterClose)` | |||
afc163
reviewed
May 23, 2018
components/message/index.zh-CN.md
Outdated
| - `message[level](content, [duration] ).then(afterClose)` | ||
| - `message[level](content, [duration], onClose ).then(afterClose)` | ||
|
|
||
| 其中`message[level]` 是组件已经提供的静态方法。`then` 接口返回值是 Promise |
|
再补充一下用例吧。 |
|
@afc163 请问建议补充怎样的用例呢？ |
|
测试 promise 用法有效并符合预期。 |
|
@afc163 请问你指的是这个 PR 中的 |
afc163
reviewed
May 23, 2018
components/message/demo/loading.md
Outdated
| @@ -19,7 +19,7 @@ import { message, Button } from 'antd'; | |||
| const success = () => { | |||
| const hide = message.loading('Action in progress..', 0); | |||
| // Dismiss manually and asynchronously | |||
| setTimeout(hide, 2500); | |||
| setTimeout(hide, 500); | |||
There was a problem hiding this comment.
I revert the change in recent commit 799bcfb. Thank you.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#10421
This PR provides the then(onClose) promise-like interface for the message
Check List
Please makes sure that these checkboxes are checked before submitting your PR, thank you!
master, feature for latest active branchfeature-x.x.npm run lintand fix those errors before submitting in order to keep consistent code style.Extra checklist:
elif isNewFeature :