Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Design pattern about message component #10421

Closed
1 task done
zhenghangjie opened this issue May 8, 2018 · 5 comments
Closed
1 task done

Design pattern about message component #10421

zhenghangjie opened this issue May 8, 2018 · 5 comments
Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive

Comments

@zhenghangjie
Copy link
Contributor

zhenghangjie commented May 8, 2018 •
edited

  • I have searched the issues of this repository and believe that this is not a duplicate.

What problem does this feature solve?

  1. why should onClose use callback not promisify like message[level](content, [duration]).then()
  2. duration has 'function' type but not reflected in docs

What does the proposed API look like?

update docs or change design pattern
@afc163
Copy link
Member

afc163 commented May 10, 2018

  1. PR is welcome~
  2. I think message.success(content, [duration], onClose) can indicate that.

@afc163 afc163 added Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. labels May 10, 2018
@zhenghangjie
Copy link
Contributor Author

upward compatible or another method ? @afc163

@afc163
Copy link
Member

afc163 commented May 10, 2018 •
edited

message.success(content, [duration]).then() would be fine.

This was referenced May 11, 2018
Closed
Merged
@zhujinxuan
Copy link
Contributor

I made a PR for this feature #10470

bors bot added a commit to mozilla/delivery-console that referenced this issue Jun 4, 2018
@bors @renovate-bot
Merge #177
433906f 
177: Update dependency antd to v3.6.1 r=rehandalal a=renovate[bot]

This Pull Request updates dependency [antd](https://github.com/ant-design/ant-design) from `v3.5.4` to `v3.6.1`



<details>
<summary>Release Notes</summary>

### [`v3.6.1`](https://github.com/ant-design/ant-design/releases/3.6.1)
[Compare Source](ant-design/ant-design@3.6.0...3.6.1)
* 🐞 修复一个 Typescript 的编译错误。

---

* 🐞 Fixing a Typescript compilation error.

---

### [`v3.6.0`](https://github.com/ant-design/ant-design/releases/3.6.0)
[Compare Source](ant-design/ant-design@3.5.4...3.6.0)
* 🌟 `Form`'s error message now can be customized with ReactNode. [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` support customized configuration for position of pagination. [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` now can be configured with `light` or `dark` theme. [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 Ant Design official site now supports offline mode. [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` adding `style` and `operationStyle` props for further customization. [@&#8203;eduludi]
* 🌟 `Message` adds a promisfied interface to handle callback. [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 Fix compilation issue with typescript@&#8203;v2.9.1 . [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 Fix a bug in `Menu` where outer menu item not highlighting while inner item is selected. [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 Affix `offsetBottom` not working. [#&#8203;10674](`ant-design/ant-design#10674)

---

* 🌟 `Form` 表单错误信息展示支持传入 ReactNode。 [#&#8203;10136](`ant-design/ant-design#10136) [@&#8203;lovekonakona]
* 🌟 `List` 组件支持指定分页器的位置。 [#&#8203;10581](`ant-design/ant-design#10581) [@&#8203;zheeeng]
* 🌟 `Layout.Sider` 支持 dark/light 主题定制。 [#&#8203;10142](`ant-design/ant-design#10142) [@&#8203;pd4d10]
* 🌟 支持 Ant Design 站点的离线模式。 [#&#8203;10625](`ant-design/ant-design#10625)
* 🌟 `Transfer` 新增 `style` 以及 `operationStyle` 属性配置样式。 [@&#8203;eduludi]
* 🌟 `Message` 增加 promise 化的回调接口。 [#&#8203;10421](`ant-design/ant-design#10421) [@&#8203;zhujinxuan]
* 🐞 修复编译时 typescript v2.9.1兼容性问题。 [#&#8203;10729](`ant-design/ant-design#10729) [@&#8203;karol-majewski]
* 🐞 修复 `Menu` 嵌套超过两层时选中最里层后对应最外层没有亮起问题。 [#&#8203;8666](`ant-design/ant-design#8666) [@&#8203;stonehank]
* 🐞 修复 `Affix` 组件 offsetBottom 无效问题。 [#&#8203;10674](`ant-design/ant-design#10674)

---

</details>




---

This PR has been generated by [Renovate Bot](https://renovatebot.com).

Co-authored-by: Renovate Bot <bot@renovateapp.com>
@viztor
Copy link
Contributor

viztor commented Jul 17, 2018

close?

@afc163 afc163 closed this as completed Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accept You are right, we should do that help wanted The suggestion or request has been accepted, we need you to help us by sending a pull request. Inactive
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@afc163 @zhujinxuan @viztor @zhenghangjie @ant-design-bot