Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Comment Component #12770

Merged
merged 24 commits into from Nov 2, 2018
Merged

Feature: Comment Component #12770

merged 24 commits into from Nov 2, 2018

Conversation

@ilanus
Copy link
Contributor

@ilanus ilanus commented Oct 22, 2018

#12739

screenshot 2018-10-30 at 14 15 44

screenshot 2018-10-30 at 14 15 57

@netlify
Copy link

@netlify netlify bot commented Oct 23, 2018

Deploy preview for ant-design ready!

Built with commit 599578c

https://deploy-preview-12770--ant-design.netlify.com

@ilanus ilanus changed the title feature: comment component Feature: comment component Oct 23, 2018
@ilanus ilanus changed the title Feature: comment component Feature: Comment Component Oct 23, 2018
components/comment/__tests__/__snapshots__/demo.test.js.snap Outdated Show resolved Hide resolved
@afc163 afc163 changed the title Feature: Comment Component [WIP] Feature: Comment Component Oct 24, 2018
@codecov
Copy link

@codecov codecov bot commented Oct 24, 2018

Codecov Report

Merging #12770 into feature will increase coverage by 0.02%.
The diff coverage is 96.55%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #12770      +/-   ##
===========================================
+ Coverage     92.6%   92.62%   +0.02%     
===========================================
  Files          215      216       +1     
  Lines         5614     5643      +29     
  Branches      1598     1619      +21     
===========================================
+ Hits          5199     5227      +28     
- Misses         409      410       +1     
  Partials         6        6
Impacted Files Coverage Δ
components/index.tsx 100% <ø> (ø) ⬆️
components/comment/index.tsx 96.55% <96.55%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update af54f50...599578c. Read the comment docs.

components/comment/style/index.less Outdated Show resolved Hide resolved
components/comment/style/index.less Outdated Show resolved Hide resolved
components/comment/style/index.less Outdated Show resolved Hide resolved
components/comment/style/index.less Outdated Show resolved Hide resolved
components/comment/style/index.less Outdated Show resolved Hide resolved
components/style/themes/default.less Outdated Show resolved Hide resolved
components/comment/demo/list.md Outdated Show resolved Hide resolved
@ilanus
Copy link
Contributor Author

@ilanus ilanus commented Oct 24, 2018

@afc163 eye of the tiger 😄updated code.. do you think we need to add also the editor mode for the comment? or user will need to take care of editor component himself? for example editor boolean will change the comment to a view like this: and user can also pass custom React Component to handle editor.. we can keep something simple as the default (Textarea)

screenshot 2018-10-24 at 15 23 51

@afc163
Copy link
Member

@afc163 afc163 commented Oct 24, 2018

we can keep something simple as the default (Textarea)

Yeay, we can put a default raw TextArea there and allow it to be replaced by other Editors that people should provide.

@afc163 afc163 requested a review from zombieJ Oct 24, 2018
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 27, 2018

这个 comment 相关的组件有点多呐,可以把内容移到 description/content/comment prop 里,然后子元素用 <Comment /> 组件来支持嵌套把 Nest 组件省了。

components/comment/demo/basic.md Outdated Show resolved Hide resolved
components/comment/demo/editor.md Outdated Show resolved Hide resolved
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Oct 27, 2018

头像和名字、时间、评论改成左右结构吧。

components/comment/index.zh-CN.md Outdated Show resolved Hide resolved
@ilanus ilanus changed the title [WIP] Feature: Comment Component Feature: Comment Component Oct 29, 2018
components/comment/index.zh-CN.md Outdated Show resolved Hide resolved
components/comment/index.zh-CN.md Outdated Show resolved Hide resolved
components/comment/index.zh-CN.md Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
components/comment/index.en-US.md Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
components/comment/index.tsx Outdated Show resolved Hide resolved
@ant-design ant-design deleted a comment from zombieJ Nov 1, 2018
@ant-design ant-design deleted a comment from zombieJ Nov 1, 2018
@zombieJ
zombieJ approved these changes Nov 2, 2018
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 2, 2018

LGTM. @afc163 pls double confirm and let's merge.

ilanus added 4 commits Nov 2, 2018
@ilanus
Copy link
Contributor Author

@ilanus ilanus commented Nov 2, 2018

@afc163 Please confirm last changes and merge if ok 😄

components/comment/demo/list.md Outdated Show resolved Hide resolved
components/comment/demo/list.md Outdated Show resolved Hide resolved
@afc163
Copy link
Member

@afc163 afc163 commented Nov 2, 2018

@ilanus Excellent job! Can't wait to release this feature in 3.11.0. 🎉

@afc163 afc163 merged commit c6821cb into ant-design:feature Nov 2, 2018
23 checks passed
23 checks passed
Header rules No header rules processed
Details
Pages changed 15 new files uploaded
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 96.55% of diff hit (target 92.6%)
Details
codecov/project 92.62% (+0.02%) compared to af54f50
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details
@zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 3, 2018

@ilanus , thanks for your patient and wonderful work 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants