ConfigProvider support prefixCls #13389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit 0bc93a3 |
Codecov Report
@@ Coverage Diff @@
## feature #13389 +/- ##
===========================================
- Coverage 92.78% 92.55% -0.24%
===========================================
Files 222 222
Lines 5810 5830 +20
Branches 1680 1681 +1
===========================================
+ Hits 5391 5396 +5
- Misses 412 429 +17
+ Partials 7 5 -2
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## feature #13389 +/- ##
===========================================
+ Coverage 92.78% 93.21% +0.42%
===========================================
Files 222 221 -1
Lines 5810 6070 +260
Branches 1680 1672 -8
===========================================
+ Hits 5391 5658 +267
+ Misses 414 407 -7
Partials 5 5
Continue to review full report at Codecov.
|
zombieJ
changed the title
zombieJ
requested review from
afc163,
chenshuai2144,
ilanus,
ycjcl868,
yesmeck and
ztplz
|
写的 👁 都要弹出来了，文件很多，大家直接看看预览对现有的样式有没有影响。没有就合了，以后有 ConfigProvider 的 issue 再单独处理。 |
|
|
|
貌似没啥问题。 |
|
review 的眼睛也很疼 |
|
这么多提交，要 squash 么？ |
|
嗯，会 squash 掉。改动文件比较多，尽快合进去，免得一直要处理冲突。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
do not merge
Note
this.prefixClsto save current renderedprefixCls.Dividerprefix isant. Change toant-dividerto keep all the prefixCls same pattern.MenupassrootPrefixClsin MenuItem & SubMenu. Use ConfigProvider also.Not change
Dropdown.ButtonoriginprefixClsnot change button under groupprefixCls.Notification.xxxdon't have context.Message.xxxdon't have context.Modal.xxxdon't have context.UploadListofUploadnot change prefixCls whenprefixClsset.