Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: table sortDirections optional #14182

Merged
merged 2 commits into from
Jan 8, 2019
Merged

fix: table sortDirections optional #14182

merged 2 commits into from
Jan 8, 2019

Conversation

ycjcl868
Copy link
Contributor

@ycjcl868 ycjcl868 commented Jan 8, 2019

Close #14170 .

First of all, thank you for your contribution! 😄

New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!

[中文版模板 / Chinese template]

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

  1. Describe the source of requirement.
  2. Resolve what problem.
  3. Related issue link.

API Realization (Optional if not new feature)

  1. Basic thought of solution and other optional proposal.
  2. List final API realization and usage sample.
  3. GIF or snapshot should be provided if includes UI/interactive modification.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  2. Chinese description (optional)

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Additional Plan? (Optional if not new feature)

If this PR related with other PR or following info. You can type here.

@ycjcl868 ycjcl868 changed the title 🐛 table sortDirections optional fix: table sortDirections optional Jan 8, 2019
@GaryChangCN
Copy link
Contributor

感谢

@netlify
Copy link

netlify bot commented Jan 8, 2019

Deploy preview for ant-design ready!

Built with commit d15660d

https://deploy-preview-14182--ant-design.netlify.com

@afc163
Copy link
Member

afc163 commented Jan 8, 2019

ci broken

@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #14182 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14182      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.02%     
==========================================
  Files         325      325              
  Lines        7106     7106              
  Branches     1789     1757      -32     
==========================================
+ Hits         6691     6693       +2     
+ Misses        403      401       -2     
  Partials       12       12
Impacted Files Coverage Δ
components/table/Table.tsx 93.57% <100%> (ø) ⬆️
components/upload/UploadList.tsx 89.74% <0%> (+1.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9f297...d15660d. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 8, 2019

Codecov Report

Merging #14182 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14182      +/-   ##
==========================================
+ Coverage   94.15%   94.18%   +0.02%     
==========================================
  Files         325      325              
  Lines        7106     7106              
  Branches     1789     1757      -32     
==========================================
+ Hits         6691     6693       +2     
+ Misses        403      401       -2     
  Partials       12       12
Impacted Files Coverage Δ
components/table/Table.tsx 93.57% <100%> (ø) ⬆️
components/upload/UploadList.tsx 89.74% <0%> (+1.7%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f9f297...d15660d. Read the comment docs.

@afc163 afc163 merged commit 3b55f63 into master Jan 8, 2019
@afc163 afc163 deleted the fix-table-sortDirections branch January 8, 2019 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TableProps sortDirections type should optional
3 participants