Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix closable Drawer hiding without transition #15147

Merged
merged 1 commit into from Mar 4, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Mar 3, 2019

This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

What's the background?

Closable Drawer hiding without transition.

When close Drawer in https://codesandbox.io/s/4r5y562pmx, the box-shadow in drawer will disappear immediately. We should add transtion on it.

API Realization (Optional if not new feature)

Look the code diff.

What's the effect? (Optional if not new feature)

  1. Does this PR affect user? Which part will be affected?
  2. What will say in changelog?
  3. Does this PR contains potential break change or other risk?

Changelog description (Optional if not new feature)

  1. English description
  • Fix closable Drawer hiding without transition.
  1. Chinese description (optional)
  • 修复关闭抽屉时浮层阴影没有缓动消失的细节。

Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@codecov

This comment has been minimized.

Copy link

commented Mar 3, 2019

Codecov Report

Merging #15147 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15147      +/-   ##
==========================================
+ Coverage   93.11%   93.16%   +0.04%     
==========================================
  Files         237      237              
  Lines        6261     6261              
  Branches     1870     1838      -32     
==========================================
+ Hits         5830     5833       +3     
+ Misses        430      427       -3     
  Partials        1        1
Impacted Files Coverage Δ
components/_util/wave.tsx 87.5% <0%> (+2.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e392605...f5573eb. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 3, 2019

Deploy preview for ant-design ready!

Built with commit f5573eb

https://deploy-preview-15147--ant-design.netlify.com

@afc163 afc163 merged commit 71a774b into master Mar 4, 2019

29 of 31 checks passed

Header rules No header rules processed
Details
Pages changed 12 new files uploaded
Details
AccessLint Review complete
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No code changes detected
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing e392605...f5573eb
Details
codecov/project 93.16% (+0.04%) compared to e392605
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-drawer-disappear branch Mar 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.