refactor: add @radio-wrapper-margin-right, @radio-checked-inner-scali… #15410
Conversation
|
Deploy preview for ant-design ready! Built with commit ce98f63 |
Codecov Report
@@ Coverage Diff @@
## master #15410 +/- ##
==========================================
- Coverage 94.23% 94.22% -0.02%
==========================================
Files 250 250
Lines 6647 6647
Branches 1930 1944 +14
==========================================
- Hits 6264 6263 -1
- Misses 382 383 +1
Partials 1 1
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #15410 +/- ##
=======================================
Coverage 94.23% 94.23%
=======================================
Files 250 250
Lines 6647 6647
Branches 1910 1910
=======================================
Hits 6264 6264
Misses 382 382
Partials 1 1Continue to review full report at Codecov.
|
components/radio/style/index.less
Outdated
| @@ -6,6 +6,8 @@ | |||
| @radio-inner-prefix-cls: ~'@{radio-prefix-cls}-inner'; | |||
| @radio-duration: 0.3s; | |||
| @radio-focused-outline: 3px solid fade(@radio-dot-color, 6%); | |||
| @radio-wrapper-margin-right: 8px; | |||
| @radio-checked-inner-scaling-value: 0.875; | |||
There was a problem hiding this comment.
Look good to me with a nit: personally I prefer @radio-checked-inner-scale for conciseness, and consistency with the naming convention here.
willc001
force-pushed
the
add-radio-wrapper-margin-right-and-radio-checked-inner-scaling-value
branch
from
3eefe14
to
ce98f63
Compare
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
Describe the source of requirement, like related issue link.
My company are theming ng-zorro-antd.
Describe the problem and the scenario.
It turns out some style declarations should be extracted to less variables for theming convenience.
💡 Solution
How to fix the problem, and list final API implementation and usage sample if that is an new feature.
GIF or snapshot should be provided if includes UI/interactive modification.
📝 Changelog description
English description
Chinese description (optional)
☑️ Self Check before Merge