Fixed an issue about the component(RangePicker) could not select the … #15427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ant-design ready! Built with commit e69c4d7 |
|
Test failed. Please check. |
|
Well, I'll fix it |
Codecov Report
@@ Coverage Diff @@
## feature #15427 +/- ##
===========================================
- Coverage 94.13% 94.1% -0.03%
===========================================
Files 250 250
Lines 6635 6637 +2
Branches 1906 1907 +1
===========================================
Hits 6246 6246
- Misses 388 390 +2
Partials 1 1
Continue to review full report at Codecov.
|
|
感觉这个 test 不太对，日期应该和以前没变化才对…… |
|
恩... 看了下 确实是的 本来是改月份模式的 却又影响到了日期模式 而且琢磨了下日期模式面板的设计又确实应该如此 RangePicker组件改起来几乎是一环套一环的 确实挺多细节需要注意 我刚改了下 本地测试已经通过了之前的快照 我再看下了 稍后提交 |
afc163
reviewed
Mar 18, 2019
zombieJ
reviewed
Mar 18, 2019
zombieJ
reviewed
Mar 18, 2019
| .last() | ||
| .getDOMNode().value, | ||
| ); | ||
| }); |
zombieJ
approved these changes
Apr 1, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…same month
First of all, thank you for your contribution! 😄
New feature please send pull request to feature branch, and rest to master branch.
Pull request will be merged after one of collaborators approve.
Please makes sure that these form are filled before submitting your pull request, thank you!
[中文版模板 / Chinese template]
🤔 This is a ...
👻 What's the background?
1.react-component/calendar#478
2.#13302
3.#15398
I added a submit for feature branch
📝 Changelog description
Fixed an issue about the component(RangePicker) could not select the same month
☑️ Self Check before Merge