Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修复月份选择时不能只选一个月的问题 #478

Merged
merged 3 commits into from
Mar 14, 2019

Conversation

alex89lj
Copy link
Contributor

issuse: ant-design/ant-design#13302

hi 我又来了 我的一个项目碰见了这个问题 看了下issuse 正好也有提到 修复了 @afc163

@ant-design-bot
Copy link

ant-design-bot commented Jan 10, 2019

Deploy preview for rc-calendar failed.

Built with commit 5bb03db

https://app.netlify.com/sites/rc-calendar/deploys/5c89cd8db361040008b41886

@codecov
Copy link

codecov bot commented Jan 15, 2019

Codecov Report

Merging #478 into master will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #478      +/-   ##
==========================================
- Coverage   89.41%   89.37%   -0.05%     
==========================================
  Files          10       10              
  Lines         671      687      +16     
  Branches      191      197       +6     
==========================================
+ Hits          600      614      +14     
- Misses         61       63       +2     
  Partials       10       10
Impacted Files Coverage Δ
src/RangeCalendar.js 87.26% <100%> (-0.17%) ⬇️
src/mixin/CommonMixin.js 100% <0%> (ø) ⬆️
src/range-calendar/CalendarPart.js 100% <0%> (ø) ⬆️
src/date/DateInput.js 85.5% <0%> (+0.43%) ⬆️
src/mixin/CalendarMixin.js 84.9% <0%> (+1.57%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebd5eec...5bb03db. Read the comment docs.

@zombieJ
Copy link
Member

zombieJ commented Feb 19, 2019

这解决了点 start month 后 end month 也可以点。
但是点了 end month 后,start month 不能点了。

@alex89lj
Copy link
Contributor Author

抱歉 疏忽了 已经修复了 这里的月份相同判断在ant-design/components/date-picker/RangePicker.tsx中也有一个 稍后会提交相应修复

@zombieJ
Copy link
Member

zombieJ commented Mar 14, 2019

担心会 break user。以防万一,我发个 minor 版本。
cc @afc163

@afc163
Copy link
Member

afc163 commented Mar 14, 2019

antd release 前多测测时间相关组件。

@afc163
Copy link
Member

afc163 commented Apr 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants