Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spin style when indicator is Icon #15712

Merged
merged 2 commits into from Mar 28, 2019

Conversation

Projects
None yet
2 participants
@afc163
Copy link
Member

commented Mar 28, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

close #15693

💡 Solution

Add classNames to i inside Spin.

📝 Changelog description

Describe changes from userside, and list all potential break changes or other risks.

  1. English description
  • 🐛 Fix Spin style when indicator is Icon. #15693
  1. Chinese description (optional)
  • 🐛 修复 Spin indicator 为 Icon 时的样式。 #15693

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@buildsize

This comment has been minimized.

Copy link

commented Mar 28, 2019

File name Previous Size New Size Change
package-lock.json [new file] 799.01 KB
@netlify

This comment has been minimized.

Copy link

commented Mar 28, 2019

Deploy preview for ant-design ready!

Built with commit 4708469

https://deploy-preview-15712--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Mar 28, 2019

Codecov Report

Merging #15712 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15712   +/-   ##
=======================================
  Coverage   95.06%   95.06%           
=======================================
  Files         250      250           
  Lines        6643     6643           
  Branches     1907     1907           
=======================================
  Hits         6315     6315           
  Misses        327      327           
  Partials        1        1
Impacted Files Coverage Δ
components/spin/index.tsx 94.73% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d0b68f9...4708469. Read the comment docs.

@netlify

This comment has been minimized.

Copy link

commented Mar 28, 2019

Deploy preview for ant-design ready!

Built with commit acd1123

https://deploy-preview-15712--ant-design.netlify.com

@ztplz

ztplz approved these changes Mar 28, 2019

@afc163 afc163 merged commit a83b7dc into master Mar 28, 2019

28 of 31 checks passed

License Compliance FOSSA is analyzing this commit
Details
Header rules No header rules processed
Details
Pages changed 18 new files uploaded
Details
Auto Assign Auto Assign
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat no reportable quality changes
Details
codecov/patch Coverage not affected when comparing d0b68f9...4708469
Details
codecov/project 95.06% remains the same compared to d0b68f9
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@delete-merged-branch delete-merged-branch bot deleted the fix-spin-style branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.