Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error types #16043

Merged
merged 2 commits into from Apr 28, 2019
Merged

fix: error types #16043

merged 2 commits into from Apr 28, 2019

Conversation

chenshuai2144
Copy link
Contributor

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

👻 What's the background?

this is error

 getPopupContainer={trigger => {
  if (trigger && trigger.parentNode) {
    return trigger.parentNode as HTMLElement;
  }
  return trigger;
}}

💡 Solution

📝 Changelog

  • TypeScript definition update
  • TypeScript 类型错误

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@chenshuai2144 chenshuai2144 changed the title Fix error types [WIP] Fix error types Apr 12, 2019
@netlify
Copy link

netlify bot commented Apr 12, 2019

Deploy preview for ant-design ready!

Built with commit 2ea47fb

https://deploy-preview-16043--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Apr 12, 2019

Codecov Report

Merging #16043 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16043      +/-   ##
==========================================
- Coverage   95.31%   95.26%   -0.05%     
==========================================
  Files         251      251              
  Lines        6741     6741              
  Branches     1967     1932      -35     
==========================================
- Hits         6425     6422       -3     
- Misses        315      318       +3     
  Partials        1        1
Impacted Files Coverage Δ
components/time-picker/index.tsx 98.64% <ø> (ø) ⬆️
components/tooltip/index.tsx 96.38% <ø> (ø) ⬆️
components/select/index.tsx 96.55% <ø> (ø) ⬆️
components/cascader/index.tsx 96.85% <ø> (ø) ⬆️
components/menu/index.tsx 97.43% <ø> (ø) ⬆️
components/config-provider/index.tsx 94.11% <ø> (ø) ⬆️
components/dropdown/dropdown.tsx 91.66% <ø> (ø) ⬆️
components/_util/wave.tsx 85.57% <0%> (-2.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab68384...2ea47fb. Read the comment docs.

@afc163
Copy link
Member

afc163 commented Apr 14, 2019

Any progress?

@chenshuai2144 chenshuai2144 changed the title [WIP] Fix error types Fix error types Apr 19, 2019
@afc163 afc163 changed the title Fix error types fix: error types Apr 28, 2019
@afc163 afc163 merged commit 30508b0 into master Apr 28, 2019
@delete-merged-branch delete-merged-branch bot deleted the fix-type branch April 28, 2019 03:47
@pr-triage pr-triage bot added the PR: merged label Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants