Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error types #16043

Merged
merged 2 commits into from Apr 28, 2019
Merged

fix: error types #16043

merged 2 commits into from Apr 28, 2019

Conversation

@chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Apr 12, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

this is error

 getPopupContainer={trigger => {
  if (trigger && trigger.parentNode) {
    return trigger.parentNode as HTMLElement;
  }
  return trigger;
}}

馃挕 Solution

馃摑 Changelog

  • TypeScript definition update
  • TypeScript 绫诲瀷閿欒

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed
@chenshuai2144 chenshuai2144 changed the title Fix error types [WIP] Fix error types Apr 12, 2019
@netlify
Copy link

@netlify netlify bot commented Apr 12, 2019

Deploy preview for ant-design ready!

Built with commit 2ea47fb

https://deploy-preview-16043--ant-design.netlify.com

@codecov
Copy link

@codecov codecov bot commented Apr 12, 2019

Codecov Report

Merging #16043 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16043      +/-   ##
==========================================
- Coverage   95.31%   95.26%   -0.05%     
==========================================
  Files         251      251              
  Lines        6741     6741              
  Branches     1967     1932      -35     
==========================================
- Hits         6425     6422       -3     
- Misses        315      318       +3     
  Partials        1        1
Impacted Files Coverage 螖
components/time-picker/index.tsx 98.64% <酶> (酶) 猬嗭笍
components/tooltip/index.tsx 96.38% <酶> (酶) 猬嗭笍
components/select/index.tsx 96.55% <酶> (酶) 猬嗭笍
components/cascader/index.tsx 96.85% <酶> (酶) 猬嗭笍
components/menu/index.tsx 97.43% <酶> (酶) 猬嗭笍
components/config-provider/index.tsx 94.11% <酶> (酶) 猬嗭笍
components/dropdown/dropdown.tsx 91.66% <酶> (酶) 猬嗭笍
components/_util/wave.tsx 85.57% <0%> (-2.89%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update ab68384...2ea47fb. Read the comment docs.

@afc163
Copy link
Member

@afc163 afc163 commented Apr 14, 2019

Any progress?

@chenshuai2144 chenshuai2144 changed the title [WIP] Fix error types Fix error types Apr 19, 2019
@afc163 afc163 changed the title Fix error types fix: error types Apr 28, 2019
@afc163 afc163 merged commit 30508b0 into master Apr 28, 2019
31 of 32 checks passed
31 of 32 checks passed
codebeat 0 issues resolved and 2 introduced
Details
@netlify[bot]
Header rules No header rules processed
Details
@netlify[bot]
Pages changed 212 new files uploaded
Details
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
CodeFactor No issues found.
Details
@dep[bot]
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
@netlify[bot]
Mixed content No mixed content detected
Details
@netlify[bot]
Redirect rules 18 redirect rules processed
Details
@semantic-pull-requests[bot]
Semantic Pull Request ready to be squashed
Details
@wip[bot]
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
@buildsize[bot]
buildsize No prior size to compare - 818.42聽KB
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
@codecov[bot]
codecov/patch Coverage not affected when comparing ab68384...2ea47fb
Details
@codecov[bot]
codecov/project 95.26% (-0.05%) compared to ab68384
Details
@netlify[bot]
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected
@delete-merged-branch delete-merged-branch bot deleted the fix-type branch Apr 28, 2019
@pr-triage pr-triage bot added the PR: merged label Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants