Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TreeNode support checkable #16369

Merged
merged 1 commit into from Apr 28, 2019

Conversation

Projects
None yet
2 participants
@zombieJ
Copy link
Member

commented Apr 28, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃懟 What's the background?

close #16316

馃挕 Solution

Upgrade rc-tree to support checkable

馃摑 Changelog

TreeNode support checkable when Tree is checkable

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Apr 28, 2019

@buildsize

This comment has been minimized.

Copy link

commented Apr 28, 2019

File name Previous Size New Size Change
package-lock.json 824.2聽KB 825.35聽KB 1.16聽KB (0%)
@netlify

This comment has been minimized.

Copy link

commented Apr 28, 2019

Deploy preview for ant-design ready!

Built with commit f21b30d

https://deploy-preview-16369--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #16369 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16369   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files          256      256           
  Lines         6845     6845           
  Branches      1953     1990   +37     
========================================
  Hits          6520     6520           
  Misses         324      324           
  Partials         1        1
Impacted Files Coverage 螖
components/tree/Tree.tsx 96.42% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 34f24a8...f21b30d. Read the comment docs.

1 similar comment
@codecov

This comment has been minimized.

Copy link

commented Apr 28, 2019

Codecov Report

Merging #16369 into feature will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           feature   #16369   +/-   ##
========================================
  Coverage    95.25%   95.25%           
========================================
  Files          256      256           
  Lines         6845     6845           
  Branches      1953     1990   +37     
========================================
  Hits          6520     6520           
  Misses         324      324           
  Partials         1        1
Impacted Files Coverage 螖
components/tree/Tree.tsx 96.42% <酶> (酶) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 34f24a8...f21b30d. Read the comment docs.

@chenshuai2144 chenshuai2144 merged commit 6e6e1ec into feature Apr 28, 2019

28 of 30 checks passed

Header rules No header rules processed
Details
Pages changed 211 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
License Compliance All checks passed.
Details
Mixed content No mixed content detected
Details
Redirect rules 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize Significant change of package-lock.json up by 1.16聽KB (0.14%)
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codebeat Target branch is not tracked
Details
codecov/patch Coverage not affected when comparing 34f24a8...f21b30d
Details
codecov/project 95.25% remains the same compared to 34f24a8
Details
deploy/netlify Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No new issues
Details

@chenshuai2144 chenshuai2144 deleted the treenode-checkable branch Apr 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.