Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: 修复纯图标按钮在默认形状下不同大小均显示为正方形 #18458

Merged
merged 1 commit into from Aug 25, 2019

Conversation

@qhanw
Copy link
Contributor

commented Aug 25, 2019

🤔 这个变动的性质是?

  • 新特性提交(功能补充)
  • 日常 bug 修复
  • 站点、文档改进
  • 组件样式改进
  • TypeScript 定义更新
  • 重构
  • 代码风格优化
  • 测试用例
  • 分支合并
  • 其他改动(是关于什么的改动?)

🔗 相关 Issue

💡 需求背景和解决方案

  1. 在使用纯图标按钮不设置形状时,按钮在默认尺寸下显示为正常正方形,而在size="large"size="small"时则高宽一不相等,具体如下。现需要在其在默认形状下不同大小均显示为正方形,可根据icon only标记进行修复。
    image

2.使用用式:<Button type="primary" icon="download" />

📝 更新日志怎么写?

语言 更新描述
🇺🇸 英文
🇨🇳 中文 根据按钮在icon only情况下修复其在默认形状下展示方式
  • 中文(可选):

☑️ 请求合并前的自查清单

  • 文档已补充或无须补充
  • 代码演示已提供或无须提供
  • TypeScript 定义已补充或无须补充
  • Changelog 已提供或无须提供

View rendered components/button/demo/button-group.md
View rendered components/button/demo/loading.md
View rendered components/button/demo/size.md
View rendered components/button/index.en-US.md
View rendered components/button/index.zh-CN.md

@pr-triage pr-triage bot added the PR: unreviewed label Aug 25, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 25, 2019

Deploy preview for ant-design ready!

Built with commit af6b213

https://deploy-preview-18458--ant-design.netlify.com

@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #18458 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18458   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         280      280           
  Lines        7522     7522           
  Branches     2089     2092    +3     
=======================================
  Hits         7252     7252           
  Misses        268      268           
  Partials        2        2
Impacted Files Coverage Δ
components/button/button.tsx 93.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271c7aa...992c5f2. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented Aug 25, 2019

Codecov Report

Merging #18458 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18458   +/-   ##
=======================================
  Coverage   96.41%   96.41%           
=======================================
  Files         280      280           
  Lines        7522     7522           
  Branches     2089     2047   -42     
=======================================
  Hits         7252     7252           
  Misses        268      268           
  Partials        2        2
Impacted Files Coverage Δ
components/button/button.tsx 93.96% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 271c7aa...af6b213. Read the comment docs.

@afc163

This comment has been minimized.

Copy link
Member

commented Aug 25, 2019

不需要添加新 shape,icon only 的时候修正为正方形就行。

@qhanw qhanw force-pushed the qhanw:feature-icon-button branch from 992c5f2 to a8b5b6c Aug 25, 2019

@qhanw qhanw changed the title 添加图标按钮形状正方形选项 修复纯图标按钮在默认形状下不同大小均显示为正方形 Aug 25, 2019

@qhanw qhanw force-pushed the qhanw:feature-icon-button branch from a8b5b6c to af6b213 Aug 25, 2019

@qhanw

This comment has been minimized.

Copy link
Contributor Author

commented Aug 25, 2019

不需要添加新 shape,icon only 的时候修正为正方形就行。

现己更正过来,新的 shape 己移除。

@afc163 afc163 changed the title 修复纯图标按钮在默认形状下不同大小均显示为正方形 style: 修复纯图标按钮在默认形状下不同大小均显示为正方形 Aug 25, 2019

@afc163 afc163 merged commit cde78c8 into ant-design:master Aug 25, 2019

26 of 29 checks passed

Semantic Pull Request Squashing a PR with only one commit will use that commit’s message. Please push an empty semantic commit.
Details
Header rules - ant-design No header rules processed
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
LGTM analysis: JavaScript No new or fixed alerts
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 96.41%)
Details
codecov/project 96.41% (+0%) compared to 271c7aa
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 25, 2019

@afc163 afc163 referenced this pull request Aug 25, 2019
5 of 14 tasks complete
@chenshuai2144 chenshuai2144 referenced this pull request Aug 26, 2019
1 of 10 tasks complete
@MrHeer MrHeer referenced this pull request Aug 27, 2019
1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.