Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: input-number less vars #18533

Merged
merged 3 commits into from Aug 29, 2019

Conversation

@ycjcl868
Copy link
Member

commented Aug 28, 2019

馃 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

馃敆 Related issue link

馃挕 Background and solution

馃摑 Changelog

Language Changelog
馃嚭馃嚫 English 馃拕 Add variables @input-number-handler-bg @input-number-handler-border-color
馃嚚馃嚦 Chinese 馃拕澧炲姞 less 鍙橀噺 @input-number-handler-bg @input-number-handler-border-color

鈽戯笍 Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@pr-triage pr-triage bot added the PR: unreviewed label Aug 28, 2019

@netlify

This comment has been minimized.

Copy link

commented Aug 28, 2019

Deploy preview for ant-design ready!

Built with commit 0329b16

https://deploy-preview-18533--ant-design.netlify.com

@@ -321,6 +321,8 @@
@input-border-color: @border-color-base;
@input-bg: @component-background;
@input-number-handler-active-bg: #f4f4f4;
@input-number-handler-wrap-bg: @component-background;

This comment has been minimized.

Copy link
@afc163

afc163 Aug 28, 2019

Member

wrap 搴旇涓嶉渶瑕併

This comment has been minimized.

Copy link
@afc163

afc163 Aug 29, 2019

Member

inner 搴旇涔熶笉闇瑕併

This comment has been minimized.

Copy link
@ycjcl868

ycjcl868 Aug 29, 2019

Author Member

杩欏潡瀹氬埗鍙兘鐢ㄥ緱鍒帮細

image

This comment has been minimized.

Copy link
@afc163

afc163 Aug 29, 2019

Member

wrap 鍜 inner 杩欎袱涓瘝鍙互浠庡彉閲忓悕涓幓鎺夈

@codecov

This comment has been minimized.

Copy link

commented Aug 28, 2019

Codecov Report

Merging #18533 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #18533   +/-   ##
=======================================
  Coverage   96.73%   96.73%           
=======================================
  Files         280      280           
  Lines        7532     7532           
  Branches     2053     2053           
=======================================
  Hits         7286     7286           
  Misses        244      244           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 9d2f62b...0329b16. Read the comment docs.

@afc163 afc163 merged commit c581dea into master Aug 29, 2019

29 of 32 checks passed

Build
Details
Header rules - ant-design No header rules processed
Details
LGTM analysis: JavaScript No code changes detected
Details
Pages changed - ant-design 214 new files uploaded
Details
DEP All dependencies are resolved
License Compliance All checks passed.
Details
Mixed content - ant-design No mixed content detected
Details
Redirect rules - ant-design 18 redirect rules processed
Details
Semantic Pull Request ready to be squashed
Details
WIP Ready for review
Details
ant-design.ant-design #ant design succeeded
Details
buildsize No change
Details
bundlesize Total bundle size is 582.38KB/600KB (-null)
Details
ci/circleci: check_metadata Your tests passed on CircleCI!
Details
ci/circleci: compile Your tests passed on CircleCI!
Details
ci/circleci: dist Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: test_dist Your tests passed on CircleCI!
Details
ci/circleci: test_dist_15 Your tests passed on CircleCI!
Details
ci/circleci: test_dom Your tests passed on CircleCI!
Details
ci/circleci: test_dom_15 Your tests passed on CircleCI!
Details
ci/circleci: test_es Your tests passed on CircleCI!
Details
ci/circleci: test_es_15 Your tests passed on CircleCI!
Details
ci/circleci: test_lib Your tests passed on CircleCI!
Details
ci/circleci: test_lib_15 Your tests passed on CircleCI!
Details
ci/circleci: test_node Your tests passed on CircleCI!
Details
ci/circleci: test_node_15 Your tests passed on CircleCI!
Details
codecov/patch Coverage not affected when comparing 9d2f62b...0329b16
Details
codecov/project 96.73% remains the same compared to 9d2f62b
Details
netlify/ant-design/deploy-preview Deploy preview ready!
Details
security/snyk - package.json (paranoidjk) No manifest changes detected

@afc163 afc163 deleted the feat-input-number-less branch Aug 29, 2019

@pr-triage pr-triage bot added PR: merged and removed PR: unreviewed labels Aug 29, 2019

@chenshuai2144 chenshuai2144 referenced this pull request Sep 2, 2019
5 of 14 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.