Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: dark theme site #18855

Closed
wants to merge 11 commits into from
Closed

style: dark theme site #18855

wants to merge 11 commits into from

Conversation

chenshuai2144
Copy link
Contributor

@chenshuai2144 chenshuai2144 commented Sep 17, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

no

💡 Background and solution

image

📝 Changelog

Language Changelog
🇺🇸 English support dark style
🇨🇳 Chinese support dark style

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

View rendered components/form/demo/advanced-search.md
View rendered docs/react/introduce.en-US.md
View rendered docs/react/introduce.zh-CN.md

@pr-triage pr-triage bot added the PR: draft label Sep 17, 2019
@netlify
Copy link

netlify bot commented Sep 17, 2019

Deploy preview for ant-design ready!

Built with commit 5a90c56

https://deploy-preview-18855--ant-design.netlify.com

@codecov
Copy link

codecov bot commented Sep 21, 2019

Codecov Report

Merging #18855 into master will decrease coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #18855      +/-   ##
==========================================
- Coverage   97.38%   96.92%   -0.46%     
==========================================
  Files         280      281       +1     
  Lines        7526     7554      +28     
  Branches     2109     2105       -4     
==========================================
- Hits         7329     7322       -7     
- Misses        196      230      +34     
- Partials        1        2       +1
Impacted Files Coverage Δ
components/_util/openAnimation.tsx 75% <0%> (-21.43%) ⬇️
components/transfer/renderListBody.tsx 90.62% <0%> (-9.38%) ⬇️
components/transfer/list.tsx 94.33% <0%> (-5.67%) ⬇️
components/date-picker/WeekPicker.tsx 94.8% <0%> (-5.2%) ⬇️
components/upload/Upload.tsx 95.45% <0%> (-3.79%) ⬇️
components/upload/UploadList.tsx 96.55% <0%> (-3.45%) ⬇️
components/transfer/index.tsx 95.48% <0%> (-3.23%) ⬇️
components/upload/utils.tsx 98.66% <0%> (-1.34%) ⬇️
components/date-picker/createPicker.tsx 98.91% <0%> (-1.09%) ⬇️
components/date-picker/RangePicker.tsx 95.06% <0%> (-0.62%) ⬇️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e3273bb...5a90c56. Read the comment docs.

@buildsize
Copy link

buildsize bot commented Sep 21, 2019

File name Previous Size New Size Change
package-lock.json 848.05 KB 853.26 KB 5.21 KB (1%)

@chenshuai2144 chenshuai2144 marked this pull request as ready for review September 21, 2019 16:27
@afc163
Copy link
Member

afc163 commented Sep 23, 2019

建议放到 4.0 里

<div style={styles.color} />
</div>
<>
<div style={styles.swatch} onClick={this.handleClick}>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

switch?

@afc163
Copy link
Member

afc163 commented Sep 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants