Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Progress): add new prop orientation to display vertically #18909

Closed

Conversation

Larissagilliane
Copy link

@Larissagilliane Larissagilliane commented Sep 19, 2019

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

Issue #18761

💡 Background and solution

Turned able the usage of Progress Bar component with vertical orientation like mentioned at isse #18761

Screen Shot 2019-09-20 at 15 28 57

To use just set the property "orientation" with "vertical" value, like "orientation='vertical' " to the Progress component.

📝 Changelog

Language Changelog
🇺🇸 English Progress add new prop orientation to display vertically
🇨🇳 Chinese Progress 新增属性 orientation 以垂直显示

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

Closes #18761


View rendered README-zh_CN.md
View rendered README.md
View rendered components/progress/demo/orientation.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md
View rendered components/tooltip/index.en-US.md
View rendered components/tooltip/index.zh-CN.md

Copy link

@tests-checker tests-checker bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add tests to make sure this change works as expected?

@netlify
Copy link

netlify bot commented Sep 19, 2019

Deploy preview for ant-design ready!

Built with commit 8907831

https://deploy-preview-18909--ant-design.netlify.com

@buildsize
Copy link

buildsize bot commented Sep 19, 2019

File name Previous Size New Size Change
package-lock.json 849.9 KB 847.35 KB -2.54 KB (0%)

@codecov
Copy link

codecov bot commented Sep 19, 2019

Codecov Report

Merging #18909 into feature will decrease coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           feature   #18909      +/-   ##
===========================================
- Coverage    96.95%   96.91%   -0.05%     
===========================================
  Files          281      281              
  Lines         7577     7541      -36     
  Branches      2116     2101      -15     
===========================================
- Hits          7346     7308      -38     
- Misses         229      231       +2     
  Partials         2        2
Impacted Files Coverage Δ
components/progress/progress.tsx 100% <100%> (ø) ⬆️
components/upload/UploadList.tsx 96.55% <0%> (-1.47%) ⬇️
components/menu/index.tsx 97.5% <0%> (-0.84%) ⬇️
components/transfer/renderListBody.tsx 90.32% <0%> (-0.31%) ⬇️
components/anchor/Anchor.tsx 94.4% <0%> (-0.22%) ⬇️
components/table/Table.tsx 95.39% <0%> (ø) ⬆️
components/_util/responsiveObserve.ts 100% <0%> (ø) ⬆️
components/breadcrumb/Breadcrumb.tsx 96.96% <0%> (ø) ⬆️
components/layout/Sider.tsx 95.6% <0%> (ø) ⬆️
components/input/Search.tsx 100% <0%> (ø) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5efb30...8907831. Read the comment docs.

luciamo
luciamo previously approved these changes Sep 20, 2019
@orzyyyy
Copy link
Contributor

orzyyyy commented Sep 21, 2019

Rebase your commits for keeping the PR clean, it's hard to review now.

@orzyyyy orzyyyy changed the title Vertical progress feat(Progress): add new prop orientation to display vertically Sep 21, 2019
@afc163
Copy link
Member

afc163 commented Sep 23, 2019

Mixed unrelated commits.

components/progress/index.en-US.md Outdated Show resolved Hide resolved
components/progress/index.zh-CN.md Outdated Show resolved Hide resolved
components/progress/demo/orientation.md Outdated Show resolved Hide resolved
components/progress/demo/orientation.md Outdated Show resolved Hide resolved
components/progress/demo/orientation.md Outdated Show resolved Hide resolved
en-US: Orientation
---

## zh-CN

通过设置`orientaton =“ vertical”`,可以将方向从水平更改为垂直。
通过设置`orientaton=“vertical”`,可以将方向从水平更改为垂直。
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

- 通过设置`orientaton=“vertical”`,
+ 通过设置 `orientaton="vertical"`,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Larissagilliane @afc163 Progress 没有找到 orientation 这个属性呢

@VIRGO96
Copy link

VIRGO96 commented Oct 12, 2019

has this been implemented in to progress bar yet ? anyone

@afc163
Copy link
Member

afc163 commented Oct 20, 2019

ping~

@willwearing
Copy link

Hey team,

Did this ever get implemented? Doesn't look like it from the documentation...

Would be a really cool feature to have If not

@ErickLee-Spok
Copy link

^^

@balboFK
Copy link

balboFK commented Mar 31, 2023

@afc163 Hello again!
Can we get a resoning why this was never merged?

@Novol1273
Copy link

So what was the final decision?
Will it ever be implemented?
Does it make sense to wait for this option to be added, or will I have to hardcode your components again?

@afc163
Copy link
Member

afc163 commented Jun 19, 2023

  1. This PR mixed unrelated commits that need to be clean.
  2. We lost contact with PR author and can't get response.
  3. PR is welcome to get it done.

@balboFK @Novol1273

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet