New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Progress): add new prop orientation to display vertically #18909
feat(Progress): add new prop orientation to display vertically #18909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add tests to make sure this change works as expected?
Deploy preview for ant-design ready! Built with commit 8907831 |
Codecov Report
@@ Coverage Diff @@
## feature #18909 +/- ##
===========================================
- Coverage 96.95% 96.91% -0.05%
===========================================
Files 281 281
Lines 7577 7541 -36
Branches 2116 2101 -15
===========================================
- Hits 7346 7308 -38
- Misses 229 231 +2
Partials 2 2
Continue to review full report at Codecov.
|
Rebase your commits for keeping the PR clean, it's hard to review now. |
Mixed unrelated commits. |
7b79cba
to
19ac682
Compare
en-US: Orientation | ||
--- | ||
|
||
## zh-CN | ||
|
||
通过设置`orientaton =“ vertical”`,可以将方向从水平更改为垂直。 | ||
通过设置`orientaton=“vertical”`,可以将方向从水平更改为垂直。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- 通过设置`orientaton=“vertical”`,
+ 通过设置 `orientaton="vertical"`,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Larissagilliane @afc163 Progress 没有找到 orientation 这个属性呢
has this been implemented in to progress bar yet ? anyone |
ping~ |
Hey team, Did this ever get implemented? Doesn't look like it from the documentation... Would be a really cool feature to have If not |
^^ |
@afc163 Hello again! |
So what was the final decision? |
|
🤔 This is a ...
🔗 Related issue link
Issue #18761
💡 Background and solution
Turned able the usage of Progress Bar component with vertical orientation like mentioned at isse #18761
To use just set the property "orientation" with "vertical" value, like "orientation='vertical' " to the Progress component.
📝 Changelog
orientation
to display verticallyorientation
以垂直显示☑️ Self Check before Merge
Closes #18761
View rendered README-zh_CN.md
View rendered README.md
View rendered components/progress/demo/orientation.md
View rendered components/progress/index.en-US.md
View rendered components/progress/index.zh-CN.md
View rendered components/tooltip/index.en-US.md
View rendered components/tooltip/index.zh-CN.md